Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint and prettier #3746

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

KristjanESPERANTO
Copy link
Contributor

This will fix #3745.

@khassel
Copy link
Collaborator

khassel commented Mar 18, 2025

the weather forecast test is now failing the 3rd time after restart, its unrelated to this PR so will merge anyway

@khassel khassel merged commit 68ec696 into MagicMirrorOrg:develop Mar 18, 2025
18 of 21 checks passed
@bugsounet
Copy link
Contributor

the weather forecast test is now failing the 3rd time after restart, its unrelated to this PR so will merge anyway

I know my word means nothing here.
However, I want to inform you of this before start writing some stupid lines of code:

SO maybe it's related to this:

Electron 35 upgrades Chromium from 132.0.6834.83 to 134.0.6998.44, Node from 20.18.1 to 22.14.0, and V8 from 13.2 to 13.5.

see there

After, do what you want... I don't care ;)

@sdetweil
Copy link
Collaborator

weather is all in browser, so shouldn't be affected by any of that.. it failed before e-35 anyhow

@bugsounet
Copy link
Contributor

sdetweil, I don't think I'm addressing you.

I think you should go back and deal with the calendar bug.
That'll save me from having to recode behind your back!

@khassel ?

@khassel
Copy link
Collaborator

khassel commented Mar 20, 2025

I know my word means nothing here.

that's not true

the mentioned weather test was already failing before the update of electron to v35, other point is, it is an e2e test so not running under electron. For me this looks like a timing issue or maybe also related at which time it runs.

Will try to dig deeper but the problem is I cannot reproduce the error locally ...

@bugsounet
Copy link
Contributor

I know my word means nothing here.

that's not true

not sure...


it's failed locally on mine but only on node v20 and not on other node version
but i read now e v35 need node v22 (and more)

Sorry for my (very very (so) ) bad english,

I won't bother you any longer,
it was just a comment about node version needed.
Good luck to you.

@bugsounet

@khassel
Copy link
Collaborator

khassel commented Mar 20, 2025

thanks, yes, we should update requirements before next release, will provide a PR for this ...

rejas pushed a commit that referenced this pull request Mar 21, 2025
see discussion in
#3746

As [electron v35 requires node js
v22.14.0](https://www.electronjs.org/blog/electron-35-0) we should
update this here too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants