-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESLint and prettier #3746
Conversation
the weather forecast test is now failing the 3rd time after restart, its unrelated to this PR so will merge anyway |
I know my word means nothing here. SO
see there After, do what you want... I don't care ;) |
weather is all in browser, so shouldn't be affected by any of that.. it failed before e-35 anyhow |
sdetweil, I don't think I'm addressing you. I think you should go back and deal with the calendar bug. @khassel ? |
that's not true the mentioned weather test was already failing before the update of electron to v35, other point is, it is an e2e test so not running under electron. For me this looks like a timing issue or maybe also related at which time it runs. Will try to dig deeper but the problem is I cannot reproduce the error locally ... |
not sure... it's failed locally on mine but only on node v20 and not on other node version Sorry for my (very very (so) ) bad english, I won't bother you any longer, |
thanks, yes, we should update requirements before next release, will provide a PR for this ... |
see discussion in #3746 As [electron v35 requires node js v22.14.0](https://www.electronjs.org/blog/electron-35-0) we should update this here too.
This will fix #3745.