Update the syntax to Python 3.10 #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
reviewed
Oct 19, 2022
| @@ -0,0 +1,59 @@ | |||
| match point: | |||
There was a problem hiding this comment.
Can you add a test with a more complicated expression in match?
There was a problem hiding this comment.
Also things like
case ["drop", *objects]:
I suggest to go though the examples here https://peps.python.org/pep-0636/
There was a problem hiding this comment.
I've added a more complex expression for match and some more variety for cases.
Generally the expressions there are not special for this grammar, so I don't expect them to mess things up. The only thing that matters is that the expressions start with something valid and not, say, ^ or %.
vpetrovykh
force-pushed
the
latest
branch
4 times, most recently
from
88ad425 to
6344093
Compare
Update the built-ins, dunders and add `match` and `case` keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the built-ins, dunders and add
matchandcasekeywords.