-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Improve marker attribute compatibility with float32converts #4869
Open
ffreyer
wants to merge
20
commits into
master
Choose a base branch
from
ff/f32c-markers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsSHA: 3cc273fad0b39146e2efdd90a846cca5892fa7d9 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4867 ... mostly...
With
markerspace == :data
marker attributes are given in pre-float32convert units and therefore should apply float32converts. This pr adds that for scatter, fast-pixel scatter and text.When
markerspace = :data
,transform_marker = true
, the model matrix contains rotation and float32convert is not an identity, then the model matrix needs to be applied on the CPU. Doing that for scatter would require rewriting the shader, as the model matrix gets applied after various other calculations.TODO:
markerspace = :pixel, transform_marker = true
in GLMakieType of change
Delete options that do not apply:
Checklist