Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Improve marker attribute compatibility with float32converts #4869

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Mar 16, 2025

Description

Fixes #4867 ... mostly...

With markerspace == :data marker attributes are given in pre-float32convert units and therefore should apply float32converts. This pr adds that for scatter, fast-pixel scatter and text.

When markerspace = :data, transform_marker = true, the model matrix contains rotation and float32convert is not an identity, then the model matrix needs to be applied on the CPU. Doing that for scatter would require rewriting the shader, as the model matrix gets applied after various other calculations.

TODO:

  • fix incorrect marker and text placement after float32convert triggers/recalculates
  • update WGLMakie
  • update CairoMakie
  • add refimage tests
  • fix broken text layout with markerspace = :pixel, transform_marker = true in GLMakie
  • fix first display time

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Mar 16, 2025

Benchmark Results

SHA: 3cc273fad0b39146e2efdd90a846cca5892fa7d9

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer marked this pull request as ready for review March 24, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

markerspace=:data breaks after zooming in
3 participants