Skip to content

drop use of unsupported_reason_add an supports_feature #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 23, 2024

part of:

Dropping use of supports_feature?. Using supports?(feature) instead
Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

@kbrock kbrock force-pushed the unsupports_supports branch from 5b69840 to 2309576 Compare February 24, 2024 04:16
@kbrock
Copy link
Member Author

kbrock commented Feb 24, 2024

update:

  • fixed missing return statements

@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2024

Checked commit kbrock@2309576 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
10 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit e0d3d0a into ManageIQ:master Feb 26, 2024
@kbrock kbrock deleted the unsupports_supports branch February 28, 2024 00:06
kbrock added a commit to kbrock/manageiq-providers-ibm_cloud that referenced this pull request Jul 1, 2024
Introduced by ManageIQ#486

you can not have a return in a block. It causes a LongJump error
Besides, it tries to return from inside the calling block - not what we want.
kbrock added a commit to kbrock/manageiq-providers-ibm_cloud that referenced this pull request Jul 1, 2024
Introduced by ManageIQ#486

you can not have a return in a block. It causes a LongJump error
Besides, it tries to return from inside the calling block - not what we want.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants