Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus http_proxy_uri host #489

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Mar 5, 2024

Same bug as described in ManageIQ/manageiq-providers-kubernetes#522

IBM Cloud Kubernetes overrides this method due to changes in the auth headers so we need to implement the same .presence fix for the http_proxy_uri

@agrare agrare added bug Something isn't working radjabov/yes? labels Mar 5, 2024
@agrare agrare requested review from Fryguy and jaywcarman as code owners March 5, 2024 19:37
@Fryguy Fryguy self-assigned this Mar 5, 2024
@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2024

Checked commit agrare@1f30ddd with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit 769fc9b into ManageIQ:master Mar 5, 2024
4 checks passed
@agrare agrare deleted the fix_prometheus_proxy_host branch March 5, 2024 19:46
@Fryguy
Copy link
Member

Fryguy commented Mar 5, 2024

Backported to radjabov in commit 16e6bf3.

commit 16e6bf3a7f70961ee4762a166665c062cbf6f999
Author: Jason Frey <[email protected]>
Date:   Tue Mar 5 14:46:21 2024 -0500

    Merge pull request #489 from agrare/fix_prometheus_proxy_host
    
    Fix prometheus http_proxy_uri host
    
    (cherry picked from commit 769fc9b83f6dc77ee2b49f728fe8da1052b676c4)

Fryguy added a commit that referenced this pull request Mar 5, 2024
Fix prometheus http_proxy_uri host

(cherry picked from commit 769fc9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working radjabov/backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants