Complete typing for logger_utils.py #4134
Conversation
| @@ -126,7 +126,7 @@ def parse_theme(parser: configparser.SectionProxy) -> Theme: | |||
| :func:`make_logger`. | |||
|
|
|||
| """ | |||
| theme = {key.replace("_", "."): parser[key] for key in parser} | |||
| theme: dict[str, Any] = {key.replace("_", "."): parser[key] for key in parser} | |||
There was a problem hiding this comment.
I might be wrong here, but I thought there is no difference between typing.Dict and dict anymore, since PEP 585 introduced generic type support for these built-in types.
There was a problem hiding this comment.
You are right. I was just thinking that you wanted to use typing everywhere ;-)
|
Hi! Could you please set |
|
I have continued work on this pull request, the updated pull request is available here: #4230 |
mypy.ini
Outdated
| [mypy-manim._config.*] | ||
| ignore_errors = True | ||
| ignore_errors = False | ||
| disable_error_code = return-value |
There was a problem hiding this comment.
This ignores errors for all files in manim/_config, which is showing multiple MyPy errors for other files which fall out of the scope of this PR. This is why pre-commit is failing in the workflows.
Instead, you'd want something like this to display only errors from the manim/_config/logger_utils.py file and ignore the rest:
[mypy-manim._config.*]
ignore_errors = True
disable_error_code = return-value
[mypy-manim._config.logger_utils]
ignore_errors = False
Motivation and Explanation: Why and how do your changes improve the library?
More work on #3375
Reviewer Checklist