Skip to content

Conversation

irvanalhaq9
Copy link
Contributor

@irvanalhaq9 irvanalhaq9 commented Mar 20, 2025

Overview: What does this pull request change?

Renamed update function dot_position to update_label in .add_updater example.

Motivation and Explanation: Why and how do your changes improve the library?

  • The previous function name dot_position was misleading because it suggested updating the dot's position.
  • The function actually updates the label's value and the label's position.
  • Renaming it to update_label improves clarity and better reflects its purpose.

Links to added or changed documentation pages

https://manimce--4196.org.readthedocs.build/en/4196/reference/manim.mobject.mobject.Mobject.html#manim.mobject.mobject.Mobject.add_updater

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@irvanalhaq9 irvanalhaq9 force-pushed the rename-dot_position-to-update_label branch from 75ff4ee to 00b1488 Compare April 20, 2025 15:20
@chopan050 chopan050 enabled auto-merge (squash) June 19, 2025 12:57
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from 🆕 New to 👍 To be merged in Dev Board Jun 19, 2025
@chopan050 chopan050 merged commit e4b1d10 into ManimCommunity:main Jun 19, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jun 19, 2025
@irvanalhaq9 irvanalhaq9 deleted the rename-dot_position-to-update_label branch June 19, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants