Skip to content

Add ZScoreNNClassifier: two-stage FDR classifier#798

Open
GeorgWa wants to merge 1 commit intomainfrom
feature/zscore-nn-classifier
Open

Add ZScoreNNClassifier: two-stage FDR classifier#798
GeorgWa wants to merge 1 commit intomainfrom
feature/zscore-nn-classifier

Conversation

@GeorgWa
Copy link
Collaborator

@GeorgWa GeorgWa commented Feb 27, 2026

Summary

  • Adds ZScoreNNClassifier, a two-stage FDR classifier that uses z-score pre-filtering on rank 0 candidates before NN training
  • Z-score stage eliminates most decoys at 50% FDR threshold, then NN trains only on survivors
  • Achieves same accuracy at 1% FDR while running ~4.5x faster on large datasets (tested on HeLa 21min: 16s vs 73s)
  • Drop-in replacement for BinaryClassifierLegacyNewBatching via the Classifier interface
  • Located in scripts/ as an experimental implementation with README documentation

🤖 Generated with Claude Code


PR Stack

Z-score pre-filtering on rank 0 candidates at 50% FDR eliminates most
decoys before NN training, achieving the same accuracy at 1% FDR while
running ~4.5x faster on large datasets.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@@ -0,0 +1,256 @@
"""Two-stage classifier: z-score pre-filter on rank 0, then NN on survivors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is superseded by #799 right? should this code here then be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants