Skip to content

MDEV-36729: ha_example::show_func_example is incorrectly defined #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-36729

Description

In the main.plugin this function is called assuming the function prototype int (*)(THD *, st_mysql_show_var *, void *, system_status_var *, enum_var_type)' as changed in b4ff645.

We update the ha_example::show_func_example to match the prototype on which it is called.

Release Notes

internal test issue.

How can this PR be tested?

Under clang UBSAN tests run the unit test main.plugin.

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • *This is a bug fix of a type than cannot be filtered with UBSAN filters that would otherwise block testing on the 10.6 branch with an updated UBSAN tester (MDBF-741).

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@grooverdan grooverdan added the MariaDB Foundation Pull requests created by MariaDB Foundation label May 2, 2025
@grooverdan grooverdan requested a review from montywi May 2, 2025 07:25
Copy link
Contributor

@montywi montywi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to push

In the main.plugin this function is called assuming the function
prototype int (*)(THD *, st_mysql_show_var *, void *, system_status_var *, enum_var_type)'
as changed in b4ff645.

We update the ha_example::show_func_example to match the prototype
on which it is called.
@mariadb-YuchenPei mariadb-YuchenPei merged commit e021a61 into MariaDB:10.6 May 29, 2025
9 checks passed
@grooverdan grooverdan deleted the MDEV-36729 branch May 29, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MariaDB Foundation Pull requests created by MariaDB Foundation
Development

Successfully merging this pull request may close these issues.

3 participants