Skip to content

Conversation

@freyazjiner
Copy link
Member

@freyazjiner freyazjiner commented Oct 23, 2025

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This PR adds a penalty_type option to the late penalty submission rules, allowing instructors to choose whether late penalties are applied as a percentage of total assignment marks (default), a fixed number of points, or a percentage of each student’s earned mark.

Screenshots of your changes (if applicable) image
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@freyazjiner freyazjiner changed the title Add penalty_type to submission_rules Add penalty_type option to submission rules for percentage_of_mark penalties Oct 23, 2025
@freyazjiner freyazjiner marked this pull request as ready for review October 23, 2025 21:31
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18797850585

Details

  • 39 of 41 (95.12%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/models/penalty_decay_period_submission_rule.rb 3 4 75.0%
app/models/penalty_period_submission_rule.rb 3 4 75.0%
Totals Coverage Status
Change from base Build 18793367624: 0.003%
Covered Lines: 42790
Relevant Lines: 45947

💛 - Coveralls

@freyazjiner freyazjiner marked this pull request as draft October 24, 2025 03:46
@freyazjiner freyazjiner removed the request for review from david-yz-liu October 24, 2025 03:46
@freyazjiner freyazjiner marked this pull request as ready for review October 24, 2025 13:13
Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @freyazjiner, I'm just leaving a few quick comments now (will wait for you to work on these and re-request a review).

  1. You made a great point at our meeting today about the % sign needing to change for different units, and please feel free to implement this. Please use the term "marks" instead of "points", both in the dropdown and for replacing the %.

  2. I've merged in #7697, which also contains a database migration. This is a bit tricky to resolve the merge correctly. Please do the following:

    1. Rollback your current migration.
    2. Update your branch from master.
    3. Perform the rails db:migrate command again. This will both run the migration from that PR, plus your own.
  • In the UI, the penalty type dropdown is a bit misaligned. It should be aligned with the other text under the option label, so that it looks like it's part of the option configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants