Repository navigation
Cache runout script pause detection - #28740
Merged
thinkyhead merged 2 commits intoOct 23, 2026
Merged
thinkyhead merged 2 commits into
thinkyhead merged 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
thinkyhead
force-pushed
the
perf/runout-script-cache
branch
from
October 23, 2026 17:46
0fd4839 to
ac8a791
Compare
Member
|
This actually has zero effect on the generated code because GCC is smart and can already see that it is generating an invariant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid repeated strstr() checks against FILAMENT_RUNOUT_SCRIPT inside the filament runout handler by caching the pause/park decision once at compile time.
This keeps the hot path minimal while preserving behavior for M600/M125/M25-based runout scripts.
Why this is a good optimization
Validation