Repository navigation
fix: port job database code to SQLAlchemy 2.0 - #1
Merged
Merged
Conversation
added 2 commits
November 16, 2026 14:38
CKAN 2.12 ships SQLAlchemy 2.x, which removed APIs this module still used (the same code was copied into ckanext-fuseki, where queuing a job failed with "Invalid argument(s) 'convert_unicode' sent to create_engine()"). - create_engine: drop convert_unicode. - MetaData(): no longer bound to an engine. - _update_job and the log handler wrote on a plain connection, which is no longer committed automatically; use engine.begin(). - Rows no longer support string indexing or dict(row); use row._mapping. - Log handler: only swallow Exception instead of a bare except. Verified with SQLAlchemy 2.0.51 against SQLite: add job, metadata, log records, complete/error/failed-to-post and lookup.
Resolve StoringHandler.emit: keep engine.begin() (SQLAlchemy 2 does not autocommit, so main's connect()/execute() never persisted log records) and keep main's stderr report when the write fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CKAN 2.12 ships SQLAlchemy 2.x, which removed APIs this module still used (the same code was copied into ckanext-fuseki, where queuing a job failed with "Invalid argument(s) 'convert_unicode' sent to create_engine()").
Verified with SQLAlchemy 2.0.51 against SQLite: add job, metadata, log records, complete/error/failed-to-post and lookup.