Add bindable DP TreeListView.SelectedItems
#3849
Conversation
…ng state when collapsing items. Tests are missing
…d even if the parent node is collapsed
| if (dataContext is TreeListViewDataBinding viewModelA) | ||
| { | ||
| Assert.Equal(2, viewModelA.SelectedItems.Count); | ||
| } | ||
| if (dataContext is TreeListViewImplicitTemplate viewModelB) | ||
| { | ||
| Assert.Equal(2, viewModelB.SelectedItems.Count); | ||
| } |
There was a problem hiding this comment.
This test tests 2 different UserControls with 2 different ViewModels. I somehow have to access the ViewModels. I know putting if-conditions in tests is not a good idea, but I opted to go this way.
Alternatively I could have created an interface to expose the SelectedItems property, but I think adding an interface just for the purpose of this test is a bit too much.
Other opinions/thoughts are welcome.
Fixing minor code issue
…w_CollapsingParentAndMovingSelection_ClearsSelectionsFromHiddenChildNode")
|
The only thing left to solve is dealing with the correct selection of duplicate items. At least this is the last and only failing test ( So far I was unable to find a solution for this. Keeping track of the selected items via reference (that's how it currently works) clearly doesn't work with duplicate items. I was trying to make it work by keeping track of the selected item(s) via their index. This however also doesn't work since the |
|
This PR is marked stale because it has been open 60 days with no activity. Remove stale label or update the PR, otherwise it will be closed in 14 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 14 days with no activity. |
nicolaihenriksen
removed
the
Stale
|
This PR is marked stale because it has been open 60 days with no activity. Remove stale label or update the PR, otherwise it will be closed in 14 days. |
github-actions
bot
added
the
Stale
Keboo
removed
the
Stale
3 participants
This adds a DP called
SelectedItemsto theTreeListViewcontrol.There was a small hurdle to overcome, because of the
TreeListViews impl., which adds (when expanding) and deletes (when collapsing) childs.Bascially internally there are now 2
SelectedItemsLists:base.SelectedItems(inherited fromListView) which only contains the visually selected itemsSelectedItems(Dependency property) which always contains all of the selected items. This is the one the consumers see/use.I also added tests for this new DP and showcases to the MD2&3 demos.