Skip to content

Convert more binary functions to sqlfunc macro #32392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 6, 2025

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented May 2, 2025

As it says on the box, convert more binary functions to the sqlfunc macro. As before, this doesn't yet use any of the new code, but it's there once we can switch over to the new implementation.

Add a output_type_expr parameter to the proc macro that allows the caller to specify an expression over the input types to compute the output type. We need this because the output type for some functions cannot be described as a type, for example for jsonb.

As before, there are tests validating meta information.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru antiguru requested a review from a team as a code owner May 2, 2025 16:00
@antiguru antiguru requested a review from ggevay May 2, 2025 16:02
antiguru added 5 commits May 5, 2025 09:40
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru force-pushed the moar_binary_funcs branch from f815f75 to 0504214 Compare May 5, 2025 07:40
@antiguru antiguru merged commit 8993e97 into MaterializeInc:main May 6, 2025
82 checks passed
@antiguru antiguru deleted the moar_binary_funcs branch May 6, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants