Convert more binary functions to sqlfunc macro#32392
Merged
antiguru merged 5 commits intoMaterializeInc:mainfrom May 6, 2025
Merged
Convert more binary functions to sqlfunc macro#32392antiguru merged 5 commits intoMaterializeInc:mainfrom
antiguru merged 5 commits intoMaterializeInc:mainfrom
Conversation
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
f815f75 to
0504214
Compare
ggevay
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says on the box, convert more binary functions to the sqlfunc macro. As before, this doesn't yet use any of the new code, but it's there once we can switch over to the new implementation.
Add a
output_type_exprparameter to the proc macro that allows the caller to specify an expression over the input types to compute the output type. We need this because the output type for some functions cannot be described as a type, for example for jsonb.As before, there are tests validating meta information.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.