Skip to content

Support directories in entry_paths#95

Merged
eimrek merged 2 commits into
mainfrom
dir-entry-paths
Apr 22, 2026
Merged

Support directories in entry_paths#95
eimrek merged 2 commits into
mainfrom
dir-entry-paths

Conversation

@eimrek

@eimrek eimrek commented Apr 18, 2026

Copy link
Copy Markdown
Member

At the moment, we only support files as entry paths:

entry_paths:
      - file: structures.zip
        matches: ["*.cif"]

but a nice and simple use case would be to also support directories here.

This pr allows this. but also renames file: to path: (in a backwards compatible way).

I also added an example: directory_of_cifs.

I think the paper won't be affected much, probably only requires changes in one figure.

@eimrek eimrek requested a review from ml-evs as a code owner April 18, 2026 16:01

@ml-evs ml-evs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, happy to merge as-is but one minor thing might be to keep one of the test cases with the old alias so that we can make sure we only break it in a controlled way in the future? e.g., a test with config_version still at 0.1.0 (I think here all the test cases have been updated?)

@eimrek

eimrek commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

thanks @ml-evs! I kept the zip_of_cifs example with the old alias ;)

@eimrek eimrek merged commit ac5ac5f into main Apr 22, 2026
4 checks passed
@eimrek eimrek deleted the dir-entry-paths branch April 22, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants