Skip to content

updated icons #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

updated icons #99

wants to merge 8 commits into from

Conversation

RUvlad1
Copy link

@RUvlad1 RUvlad1 commented Apr 29, 2025

this is an incomplete first set of icons i made for jankclient, i haven't made much progress in a while so i'm just adding everything that was made so far and I Will try to create the rest

also some of the icons in jc itself should be resized to 18x18 to avoid blurriness but that isn't part of this pr

RUvlad1 added 6 commits April 16, 2025 23:28
not a whole lot but whatever
probably doesnt matter as much but might as well keep it the same for consistencuy
@RUvlad1
Copy link
Author

RUvlad1 commented Apr 29, 2025

(ignore the readme changes btw this is Baby's first PR and i couldn't figure out how to undo it )

@MathMan05
Copy link
Owner

you're fine the readme changes are net neutral, is this meant to be merged or track?

@RUvlad1
Copy link
Author

RUvlad1 commented Apr 29, 2025

you're fine the readme changes are net neutral, is this meant to be merged or track?

tbh idk, if it doesn't mess up the things that aren't supposed to be changed (the readme) then that's fine

@MathMan05
Copy link
Owner

I ask cause I wasn't sure if you were done and there's no harm, dw

@RUvlad1
Copy link
Author

RUvlad1 commented Apr 29, 2025

I ask cause I wasn't sure if you were done and there's no harm, dw

oh if you mean the icons then Yeah I haven't Fully remade them yet, this is only what's been made so far

@MathMan05
Copy link
Owner

would you like me to wait, the pull request will update with your branch

@RUvlad1
Copy link
Author

RUvlad1 commented May 3, 2025

would you like me to wait, the pull request will update with your branch

if you mean it will update when i update the fork i made for the icons then yeah that should be fine

@MathMan05
Copy link
Owner

That's how it works! Let me know when you want me to review for merge then

@MathMan05 MathMan05 self-assigned this May 3, 2025
@MathMan05 MathMan05 added the enhancement New feature or request label May 3, 2025
@MathMan05 MathMan05 marked this pull request as draft May 3, 2025 15:26
@MathMan05
Copy link
Owner

actually, you should be able to convert it back on your own

@RUvlad1 RUvlad1 marked this pull request as ready for review May 3, 2025 18:23
@MathMan05
Copy link
Owner

shoot, this is complete?

@RUvlad1
Copy link
Author

RUvlad1 commented May 3, 2025

shoot, this is complete?

fuCK i mindlessly clicked on it and forgot about it They're not done yet

@MathMan05 MathMan05 marked this pull request as draft May 3, 2025 20:57
@MathMan05
Copy link
Owner

it's ok, accidents happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants