-
-
Notifications
You must be signed in to change notification settings - Fork 62
InputForm #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for doing this! I will try to look at in detail later today. |
mathics/form/inputform.py
Outdated
| """ | ||
| This module builts the string associated to the InputForm. | ||
|
|
||
| `InputForm` produces a textual output suitable for being parsed and directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment here should probably go into the user manual (and then removed or condensed) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change that - the user doc for "InputForm"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see first if this is clear enough. Then we can rephrase the part that makes sense at the user level in the docstring of InputForm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was in the process of trying to understand what's up here. I'll put in a PR to merge tomorrow.
There were other small things I saw along this vein.
mathics/form/inputform.py
Outdated
| format_expr, evaluation, **kwargs | ||
| ) | ||
| return result | ||
| except _WrongFormattedExpression as e: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in the following except clause, e is not used. Either use or remove.
|
LGTM. So I guess we can move on to OutputForm. |
This reimplements InputForm