Skip to content

Conversation

@mmatera
Copy link
Contributor

@mmatera mmatera commented Jan 7, 2026

This reimplements InputForm

@rocky
Copy link
Member

rocky commented Jan 7, 2026

Thanks for doing this! I will try to look at in detail later today.

@mmatera
Copy link
Contributor Author

mmatera commented Jan 7, 2026

PRs #1602 - #1605 contains the part of this PR which are not directly related, and can be analyzed separately,

@rocky
Copy link
Member

rocky commented Jan 7, 2026

PRs #1602 - #1605 contains the part of this PR which are not directly related, and can be analyzed separately,

I appreciate your separating PRs into smaller separable ones. Thanks.

"""
This module builts the string associated to the InputForm.

`InputForm` produces a textual output suitable for being parsed and directly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here should probably go into the user manual (and then removed or condensed) here.

Copy link
Member

@rocky rocky Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change that - the user doc for "InputForm"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see first if this is clear enough. Then we can rephrase the part that makes sense at the user level in the docstring of InputForm.

Copy link
Member

@rocky rocky Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was in the process of trying to understand what's up here. I'll put in a PR to merge tomorrow.

There were other small things I saw along this vein.

format_expr, evaluation, **kwargs
)
return result
except _WrongFormattedExpression as e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in the following except clause, e is not used. Either use or remove.

mmatera and others added 5 commits January 7, 2026 22:01
@rocky
Copy link
Member

rocky commented Jan 9, 2026

LGTM.

So I guess we can move on to OutputForm.

@mmatera mmatera merged commit b3945a3 into master Jan 9, 2026
21 checks passed
@mmatera mmatera deleted the InputForm branch January 9, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants