Stdout standardization with output formatter#56
Merged
Conversation
Member
|
This can be incrementally cherry-picked? Or will you do it one go? |
Member
|
Cherry pick relevant commits back to staging @amydevs |
Closed
Contributor
Author
|
the first two commits have been cherrypicked into staging, remember to rebase after |
Member
|
You should rebase this PR if you've cherrypicked, since then this will be left with just 1 commit! Otherwise it will be confusing. |
986f63b to
ff9345e
Compare
ff9345e to
7329770
Compare
Member
|
There's still a problem here: #124 (comment) |
Member
2a08f93 to
a986613
Compare
ce60f6d to
6ff85b3
Compare
Member
|
Can you expand the task list so we know how close we are finishing this? |
Member
|
@amydevs where's the counter? |
3ad9573 to
9017511
Compare
…ts/CommandPermissions.ts` now uses `vaultPermissionList`
…er follow RPC response
fix: whitespace on `identities/CommandList` fix: `test/identities/trustUntrustList.test.ts`
962fa32 to
c38fb62
Compare
feat: `dict` formatter now also supports nested arrays fix: `outputFormatterDict` will not have incorrect output when an array element is a number
… their double newlines removed
…iate each notification
c38fb62 to
18d223c
Compare
This was referenced Mar 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes all the CLI stdout inconsistencies, this is kind of tedious and not critical at the moment though.
Changelog
{ claimId: string; url?: string }.logger.infoso that it goes to stderrDict Format
This PR also implements changes to the dict format that allows for nesting.
Changes made to commands with this:
agent/CommandStatusidentities/CommandListnotificiations/CommandReadIssues Fixed
dictFormat Nesting #158Tasks
listformatted outputs to just be strings.listformatted outputs to just bedicts.jsonformatted outputs to return structured POJO rather than just an array with the message itself.dictformatFinal checklist