Skip to content

Conversion to ESM #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Mar 25, 2025

Description

This PR addresses converting Polykey to ESM

Issues Fixed

Tasks

  • 1. Convert to ESM

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

Copy link

linear bot commented Mar 25, 2025

ENG-555

@tegefaulkes tegefaulkes marked this pull request as draft March 25, 2025 05:14
@tegefaulkes tegefaulkes self-assigned this Mar 25, 2025
@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 25, 2025

Made a start on the conversion. It's still blocked by a few dependencies that need a release. @brynblack should be fixing them up but I may take over some of them if needed.

Besides that there are a few fixes that need to be done.

  1. The timed cancellable import decorators and functions need to be cleaned up with an aliased name.
  2. Some encryptedfs exports need to be added. Some types can't be found on the top level.
  3. ESM version of multiformats needs to be used. Or clean up the broken import. Whatever works.
  4. some IdSortable utilities don't have a top level export for them. That needs to be fixed up.
  5. Fix up the workerManager usage of workers.

@CMCDragonkai
Copy link
Member

Made a start on the conversion. It's still blocked by a few dependencies that need a release. @brynblack should be fixing them up but I may take over some of them if needed.

Besides that there are a few fixes that need to be done.

  1. The timed cancellable import decorators and functions need to be cleaned up with an aliased name.
  2. Some encryptedfs exports need to be added. Some types can't be found on the top level.
  3. ESM version of multiformats needs to be used. Or clean up the broken import. Whatever works.
  4. some IdSortable utilities don't have a top level export for them. That needs to be fixed up.
  5. Fix up the workerManager usage of workers.

If there's a wholesale update of the way async-init works, it may be worth looking into MatrixAI/js-async-init#22.

Also get @Abby010 involved in this in relation to integrating the tracing system and being able to compositionally hook into the events.

@aryanjassal needs to have some understanding of #444.

@tegefaulkes tegefaulkes marked this pull request as ready for review April 3, 2025 02:00
@tegefaulkes tegefaulkes force-pushed the feature-eng-555-polykey-migration-to-esm branch from 07860c0 to cf3f824 Compare April 3, 2025 02:22
@tegefaulkes tegefaulkes force-pushed the feature-eng-555-polykey-migration-to-esm branch from cf3f824 to 1fc7e7d Compare April 3, 2025 02:33
@tegefaulkes tegefaulkes merged commit 67e4f65 into staging Apr 3, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Polykey: Migration to ESM
2 participants