Skip to content

Integrate js-lint and removing old linting elements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

CDeltakai
Copy link
Contributor

@CDeltakai CDeltakai commented Apr 22, 2025

Description

This PR integrates the new js-lint package and removes old linting elements

Issues Fixed

Tasks

  • 1. Integrate js-lint and ensure it works as expected.
  • 2. Remove old linting elements as they are no longer needed.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CDeltakai CDeltakai self-assigned this Apr 22, 2025
@CDeltakai CDeltakai requested a review from tegefaulkes May 9, 2025 06:26
@CDeltakai
Copy link
Contributor Author

Seems like rebasing is a constant pain - the package-lock.json keeps causing merge conflicts even after I've seemingly resolved. Could you give this a quick look over @tegefaulkes ?

@tegefaulkes
Copy link
Contributor

Don't try to fix the package lock. Take whatever is on staging and then just run an npm install to update it. Can @aryanjassal look it over?

@tegefaulkes tegefaulkes force-pushed the feature-integrate-js-lint branch from 124af47 to aa6fcc5 Compare May 12, 2025 05:14
@tegefaulkes tegefaulkes force-pushed the feature-integrate-js-lint branch from aa6fcc5 to 13c8f3b Compare May 12, 2025 05:16
@CDeltakai CDeltakai merged commit cccd7e8 into staging May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

js-workers: Integrate js-lint
2 participants