-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChangeLog for rng #10074
base: development
Are you sure you want to change the base?
Add ChangeLog for rng #10074
Conversation
a73456a
to
6188789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in related PR, could we have absolute links?
ChangeLog.d/removal-of-rng.txt
Outdated
@@ -2,4 +2,5 @@ API changes | |||
* All API functions now use the PSA random generator psa_get_random() | |||
internally. As a consequence, functions no longer take RNG parameters. | |||
Please refer to the migration guide at : | |||
https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[4.0-migration-guide.md](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/tf-psa-crypto/docs/4.0-migration-guide.md)
'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
f2c1c27
to
089da59
Compare
Sorry I did not think it through. We should be using markdown links on documentation but not on changelogs. Could you please revert it to the relative pointer? |
089da59
to
b430f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add a generic ChangeLog entry for the rng removal that points to the migration guide. depends Mbed-TLS/TF-PSA-Crypto#214 resolves #10028
PR checklist