Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChangeLog for rng #10074

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Mar 19, 2025

Description

Add a generic ChangeLog entry for the rng removal that points to the migration guide. depends Mbed-TLS/TF-PSA-Crypto#214 resolves #10028

PR checklist

  • changelog provided
  • development PR provided #HERE
  • TF-PSA-Crypto PR provided Add migration guide and ChangeLog TF-PSA-Crypto#214
  • framework PR not required
  • 3.6 PRnot required because: No backports
  • 2.28 PR not required because: No backports
  • tests not required because: No changes

@bjwtaylor bjwtaylor added the needs-reviewer This PR needs someone to pick it up for review label Mar 21, 2025
@bjwtaylor bjwtaylor marked this pull request as ready for review March 21, 2025 07:37
@bjwtaylor bjwtaylor added the needs-review Every commit must be reviewed by at least two team members, label Mar 21, 2025
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in related PR, could we have absolute links?

@@ -2,4 +2,5 @@ API changes
* All API functions now use the PSA random generator psa_get_random()
internally. As a consequence, functions no longer take RNG parameters.
Please refer to the migration guide at :
https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[4.0-migration-guide.md](https://github.com/Mbed-TLS/TF-PSA-Crypto/blob/development/docs/tf-psa-crypto/docs/4.0-migration-guide.md)
'

minosgalanakis
minosgalanakis previously approved these changes Mar 27, 2025
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ben Taylor added 2 commits March 28, 2025 07:47
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
@minosgalanakis
Copy link
Contributor

Sorry I did not think it through. We should be using markdown links on documentation but not on changelogs. Could you please revert it to the relative pointer? docs/4.0-migration-guide.md or reset simply the head to this commit b430f82

Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for removing explicit RNG arguments
2 participants