Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular install for CI tests #463

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Mar 28, 2024

The CI tests are now installed with a regular pip install, rather than being installed editabally. This ensures they are more realistic.

  • Investigate why the coverage has dropped because of this. (It seems the CLI tests are being missed.)

@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Mar 28, 2024
@jfrost-mo jfrost-mo changed the title Test normal install Use regular install for CI tests Mar 28, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Coverage

@jfrost-mo jfrost-mo self-assigned this Apr 19, 2024
@jfrost-mo
Copy link
Member Author

Probably the thing to do is to ditch the end-to-end CI tests, just keeping the --help one for validating that the cset command still works, and instead test the code inside __init__.py more explicitly.

This will probably involve marking the if __name__ == "__main__" bit as noqa, as I don't thing we can measure coverage on those couple lines.

@@ -37,7 +37,7 @@ jobs:
run: |
# Install package and run pytest.
echo '::group::Installing local package'
python3 -m pip install -e .
python3 -m pip install .
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the test coverage to drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant