Update socrates and jules extraction and compilation flags #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de_paths_socrates
This reverts commit b0d4e7f.
jasonjunweilyu
changed the title
hiker
requested changes
Feb 21, 2025
| FcmExtract(self.lfric_apps_root / "science" / | ||
| "socrates_interface" / "build" / | ||
| "extract.cfg"), | ||
| FcmExtract(self.lfric_apps_root / "science" / |
There was a problem hiding this comment.
That seems only to work with recent LFRic versions. We still need to support LFRic versions before the change in the extract.cfg files happened. So I'd guess you need to check that the files exists before creating FcmExtract's for them,
added 2 commits
February 21, 2025 17:29
… Pointed FAB to develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the extraction and build of socrates and jules for lfric_atm, based on the same update of this ticket: https://code.metoffice.gov.uk/trac/lfric_apps/ticket/539
The pipeline build is successful: https://git.nci.org.au/bom/ngm/lfric/lfric_atm-fab/-/commit/88db61f0f2a7991d79c995aa9c050e524dba136e