Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FCI on Meteosat-12 varobs and CX namelists and test files #235

Merged
merged 14 commits into from
Feb 17, 2025

Conversation

PJLevensMO
Copy link
Contributor

This PR adds the files needed for processing FCI data in the UKV, as well as updating the inbuilt OPS routines to handle FCI/Met-12 data.

@smnewman
Copy link
Contributor

Hi @PJLevensMO, are these changes in deps/ops being mirrored in OPS?

@PJLevensMO
Copy link
Contributor Author

Hi @PJLevensMO, are these changes in deps/ops being mirrored in OPS?

The changes in OPS are tracked in this ticket: https://code.metoffice.gov.uk/trac/ops/ticket/2961

It has been a while since I've compared the two, I will check that everything covered here is the same in the OPS branch

@PJLevensMO
Copy link
Contributor Author

@smnewman I've found a couple of files that are either missing updates vs. OPS or could be tidied up. I'll just edit those and push the changes.

Copy link
Contributor

@smnewman smnewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @PJLevensMO. I assume it's not possible to test the code in sith until we have real data?

@PJLevensMO
Copy link
Contributor Author

Looks good to me @PJLevensMO. I assume it's not possible to test the code in sith until we have real data?

We do have real data now, I ran some tests ages ago on the test data which worked fine. I can try and set up a sith test which uses the operational data just to test the code works, if that would be useful?

@smnewman
Copy link
Contributor

Looks good to me @PJLevensMO. I assume it's not possible to test the code in sith until we have real data?

We do have real data now, I ran some tests ages ago on the test data which worked fine. I can try and set up a sith test which uses the operational data just to test the code works, if that would be useful?

I think some sith output would be a useful sanity check, if feasible.

@PJLevensMO
Copy link
Contributor Author

I'll get that set up. With the caviat that this would purely be a technical test - the output might be nonsense (R matrix and biases have not been tuned for FCI, so using SEVIRI as a baseline) and JOPA yamls have not been properly implemented yet.

@PJLevensMO
Copy link
Contributor Author

PJLevensMO commented Feb 17, 2025

It has taken a little while to get sith working, there is a problem with the VarBC file I had been using (unrelated to this PR). Removing that, however, the opsinputs parts work as expected. See the output at http://fcm1/cylc-review/taskjobs/plevens/?suite=fci_test%2Frun19

@mikecooke77
Copy link
Collaborator

I have just deleted the files and regenerated locally before running the ctests and all ctests pass. This will not affect KGOs and is therefore being merged.

@mikecooke77 mikecooke77 merged commit 2720b0b into develop Feb 17, 2025
6 checks passed
@mikecooke77 mikecooke77 deleted the feature/fci branch February 17, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants