Skip to content

feat: bitcoin account types #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 21, 2025
Merged

feat: bitcoin account types #284

merged 10 commits into from
May 21, 2025

Conversation

darioAnongba
Copy link
Contributor

@darioAnongba darioAnongba commented May 5, 2025 •
edited
Loading

  • Adds support for remaining Bitcoin account types.
  • Adds stricter validation checks for the decoding of the addresses. Removes bech32 dependency in favor of bitcoin-address-validation.
  • Removes size limit of scopes for Bitcoin accounts as testnet accounts span multiple scopes. testnet, testnet4 and signet are the same account (same address).

p2sh is a shortcut for p2wpkh-p2sh (nested segwit).

@darioAnongba darioAnongba self-assigned this May 5, 2025
@darioAnongba darioAnongba marked this pull request as ready for review May 5, 2025 12:31
@darioAnongba darioAnongba requested review from a team as code owners May 5, 2025 12:31
ccharly
ccharly reviewed May 15, 2025
View reviewed changes
ccharly
ccharly reviewed May 21, 2025
View reviewed changes
@ccharly ccharly added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 697d126 May 21, 2025
31 checks passed
@ccharly ccharly deleted the feat/bitcoin-account-types branch May 21, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

Assignees

@darioAnongba darioAnongba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darioAnongba @ccharly