Skip to content

perf(base-controller): prevent unnecessary state update #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(base-controller): prevent unnecessary state update #5719

wants to merge 1 commit into from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 28, 2025

Explanation

TODO

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly changed the title pref: prevent unnecessary state update perf: prevent unnecessary state update Apr 28, 2025
@ccharly ccharly force-pushed the perf/prevent-unnecessary-state-update branch 2 times, most recently from 5daec17 to c8e4f03 Compare April 28, 2025 21:39
@ccharly ccharly force-pushed the perf/combined-accounts-controller-actions branch from aabb780 to ded28ee Compare April 28, 2025 21:55
@ccharly ccharly force-pushed the perf/prevent-unnecessary-state-update branch from c8e4f03 to cd5c2df Compare April 28, 2025 21:55
@ccharly ccharly force-pushed the perf/combined-accounts-controller-actions branch from ded28ee to 3428d20 Compare April 29, 2025 08:09
@ccharly ccharly force-pushed the perf/prevent-unnecessary-state-update branch from cd5c2df to 533502d Compare April 29, 2025 08:16
@ccharly ccharly changed the title perf: prevent unnecessary state update perf(base-controller): prevent unnecessary state update Apr 29, 2025
@ccharly ccharly force-pushed the perf/prevent-unnecessary-state-update branch from 533502d to b98591f Compare April 29, 2025 12:40
@ccharly ccharly changed the base branch from perf/combined-accounts-controller-actions to main April 29, 2025 14:13
@ccharly ccharly linked an issue Apr 30, 2025 that may be closed by this pull request
[Bug]: performance degradation during account creation MetaMask/metamask-mobile#14864
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation
1 participant
@ccharly