Skip to content

perf(keyring-controller): add withReadonlyKeyring action #5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Apr 29, 2025

Explanation

Add new action withReadonlyKeyring when we need to access a specific reading and read some data from it while being guarded by the global controller mutex.

This helps quite a bit with Snap account creation flow (especially on mobile) given that we need to access an HD keyring to derive keys.

References

N/A

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ccharly ccharly force-pushed the perf/with-readonly-keyring branch from 9e84933 to 87b68d7 Compare April 29, 2025 12:36
@ccharly ccharly changed the title perf(keyring-controller): add withReadonlyKeyring action perf(keyring-controller): add withReadonlyKeyring action Apr 29, 2025
@ccharly ccharly force-pushed the perf/with-readonly-keyring branch from 87b68d7 to 8eb80ce Compare April 29, 2025 12:39
@ccharly ccharly force-pushed the perf/prevent-unnecessary-state-update branch from 533502d to b98591f Compare April 29, 2025 12:40
@ccharly ccharly changed the base branch from perf/prevent-unnecessary-state-update to main April 29, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant