Skip to content

fix(multichain-network-controller): batch requests for active networks #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

Explanation

This PR implements request batching for the Network Activity API to accommodate a new limitation imposed by the API platform team. The API endpoint now caps requests at 20 account IDs per call to prevent URL length limitations in some browsers.

Key Changes

  • Modified MultichainNetworkService to handle batching of account IDs in groups of 20
  • Added internal batch processing logic to maintain the same public interface
  • Updated tests to validate correct batching behavior

References

Related to #4469

Changelog

NA

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

…p the network requests for users with large amount of addresses
@vinnyhoward vinnyhoward requested review from a team as code owners May 2, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant