Skip to content

Release 388.0.0 #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 6, 2025
Merged

Release 388.0.0 #5763

merged 8 commits into from
May 6, 2025
+230 −152

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented May 6, 2025

Release candidates that includes some important perf improvements for the Snap account creation flow.

  • Prevent some unnecessary KeyringController:stateChange when using withKeyring
  • Prevent some unnecessary AccountsController:stateChange when handling SnapController:stateChange
  • Combine multiple actions into 1, to avoid multiple .update blocks

@ccharly ccharly changed the title Release/388.0.0 Release 388.0.0 May 6, 2025
@ccharly ccharly marked this pull request as ready for review May 6, 2025 09:59
@ccharly ccharly requested review from a team as code owners May 6, 2025 09:59
@ccharly ccharly self-assigned this May 6, 2025
gantunesr
gantunesr approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyring-controller and accounts-controller ✅

cryptodev-2s
cryptodev-2s approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly merged commit f0742fa into main May 6, 2025
202 checks passed
@ccharly ccharly deleted the release/388.0.0 branch May 6, 2025 12:58
@ccharly ccharly linked an issue May 6, 2025 that may be closed by this pull request
[Bug]: performance degradation during account creation MetaMask/metamask-mobile#14864
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

Assignees

@ccharly ccharly

Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation
3 participants
@ccharly @gantunesr @cryptodev-2s