feat: add lending functionality to controller #5828
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "name": "@metamask/earn-controller", | ||||||
| "version": "1.0.0", | ||||||
|
There was a problem hiding this comment. @nickewansmith Would you mind reverting this change? Just so you're aware, updating the changelog ahead of time is fine, but we don't bump the version of a package until we are ready to release that package, and we do that in a separate release PR for visibility. Release PRs get created via
Suggested change
|
||||||
| "description": "Manages state for earning features and coordinates interactions between staking services, SDK integrations, and other controllers to enable users to participate in various earning opportunities", | ||||||
| "keywords": [ | ||||||
| "MetaMask", | ||||||
|
|
@@ -47,10 +47,12 @@ | |||||
| "since-latest-release": "../../scripts/since-latest-release.sh" | ||||||
| }, | ||||||
| "dependencies": { | ||||||
| "@ethersproject/bignumber": "^5.7.0", | ||||||
| "@ethersproject/providers": "^5.7.0", | ||||||
| "@metamask/base-controller": "^8.0.1", | ||||||
| "@metamask/controller-utils": "^11.9.0", | ||||||
| "@metamask/stake-sdk": "3.2.0", | ||||||
| "reselect": "^5.1.1" | ||||||
| }, | ||||||
| "devDependencies": { | ||||||
| "@metamask/accounts-controller": "^29.0.0", | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm,
stake-sdkdoesn't seem like a peer dependency, it seems like a regular dependency. So this doesn't seem like a breaking change to me. Also, it seems we've added two new dependencies: