Correct invalid initial selectedNetworkClientId #5851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
force-pushed
the
handle-invalid-selected-network-client-id
branch
from
291f6b3 to
3d36c69
Compare
Currently, when NetworkController is instantiated with pre-existing state that contains an invalid `selectedNetworkClientId` — that is, no RPC endpoint exists which has the same network client ID — then it throws an error. This was intentionally done to bring attention to possible bugs in NetworkController, but this has the unfortunate side effect of bricking users' wallets. To fix this, we now correct an invalid `selectedNetworkClientId` to point to the default RPC endpoint of the first network sorted by chain ID (which in the vast majority of cases will be Mainnet). We still do want to know about this, though, so we log the error in Sentry.
mcmire
force-pushed
the
handle-invalid-selected-network-client-id
branch
from
3d36c69 to
409b54c
Compare
mcmire
commented
May 23, 2025
| NetworkControllerActions, | ||
| NetworkControllerEvents | ||
| >; | ||
| messenger: RootMessenger; |
There was a problem hiding this comment.
The type of the messenger in these tests only took internal actions and events into consideration and not external actions, so I've had to correct all of them.
| @@ -87,7 +89,7 @@ export function buildNetworkControllerMessenger( | |||
| ): NetworkControllerMessenger { | |||
| return messenger.getRestricted({ | |||
| name: 'NetworkController', | |||
| allowedActions: [], | |||
| allowedActions: ['ErrorReportingService:captureException'], | |||
There was a problem hiding this comment.
Here we need to add ErrorReportingService:captureException to the list of external actions because we are now using it in the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, when NetworkController is instantiated with pre-existing state that contains an invalid
selectedNetworkClientId— that is, no RPC endpoint exists which has the same network client ID — then it throws an error. This was intentionally done to bring attention to possible bugs in NetworkController, but this has the unfortunate side effect of bricking users' wallets.To fix this, we now correct an invalid
selectedNetworkClientIdto point to the default RPC endpoint of the first network sorted by chain ID (which in the vast majority of cases will be Mainnet). We still do want to know about this, though, so we log the error in Sentry.References
Fixes #5739.
Checklist