feat: Default addTransactionBatch to EIP7702 if supported, otherwise use sequential batch #5853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
b46ad98 to
6f74606
Compare
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
6f74606 to
37d55f9
Compare
matthewwalsh0
requested changes
May 23, 2025
packages/transaction-controller/src/hooks/ExtraTransactionsPublishHook.ts
Show resolved
Hide resolved
pedronfigueiredo
force-pushed
the
pnf/4991
branch
5 times, most recently
from
8808f3d to
96e2cdd
Compare
…e use sequential batch
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
96e2cdd to
cb180c9
Compare
matthewwalsh0
requested changes
May 28, 2025
| useHook: true, | ||
| disable7702: true, | ||
| disableHook: false, | ||
| disableSequential: false, |
There was a problem hiding this comment.
This also has be true as we only want to use smart transactions here, to trigger gas station, and ensure it's atomic.
| * Defaults to false. | ||
| */ | ||
| useHook?: boolean; | ||
| /** Whether or not to disable batch transaction processing through an EIP 7702 upgraded account. */ |
There was a problem hiding this comment.
Suggested change
| /** Whether or not to disable batch transaction processing through an EIP 7702 upgraded account. */ | |
| /** Whether to disable batch transaction processing via an EIP-7702 upgraded account. */ |
| /** Whether or not to disable batch transaction processing through an EIP 7702 upgraded account. */ | ||
| disable7702?: boolean; | ||
|
|
||
| /** Whether or not to disable batch transaction processing through a hook. */ |
There was a problem hiding this comment.
Suggested change
| /** Whether or not to disable batch transaction processing through a hook. */ | |
| /** Whether to disable batch transaction via the `publishBatch` hook. */ |
| /** Whether or not to disable batch transaction processing through a hook. */ | ||
| disableHook?: boolean; | ||
|
|
||
| /** Whether or not to disable batch transaction through sequential batching. */ |
There was a problem hiding this comment.
Suggested change
| /** Whether or not to disable batch transaction through sequential batching. */ | |
| /** Whether to disable batch transaction via sequential transactions. */ |
| if (useHook) { | ||
| return await addTransactionBatchWithHook(request); | ||
| if (!transactionBatchRequest.disable7702) { | ||
| return await addTransactionBatchWith7702(request); |
There was a problem hiding this comment.
Does this not mean that if 7702 is enabled, but the chain isn't supported, it will throw and not fallback to anything else?
Do we need to use a try catch and only handle the specific chain not supported error?
| (!transactionBatchRequest.disableSequential && | ||
| sequentialPublishBatchHook.getHook()); | ||
| if (!publishBatchHook) { | ||
| log(`Can't process batch`, { |
There was a problem hiding this comment.
Suggested change
| log(`Can't process batch`, { | |
| log(`No supported batch methods found`, { |
| sequentialPublishBatchHook.getHook()); | ||
| if (!publishBatchHook) { | ||
| log(`Can't process batch`, { | ||
| disable7702: transactionBatchRequest.disable7702, |
There was a problem hiding this comment.
Minor, could we destructure these above?
|
|
||
| const chainId = getChainId(networkClientId); | ||
| const batchId = generateBatchId(); | ||
| const transactionCount = nestedTransactions.length; | ||
| const collectHook = new CollectPublishHook(transactionCount); | ||
| try { | ||
| if (requireApproval && useHook) { | ||
| if (requireApproval) { |
There was a problem hiding this comment.
Good spot, if we've made it here, we're not doing the 7702 flow.
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
e9419d7 to
4748992
Compare
OGPoyraz
reviewed
Jun 2, 2025
OGPoyraz
previously approved these changes
Jun 2, 2025
Co-authored-by: OGPoyraz <[email protected]>
OGPoyraz
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We previously relied on the
useHookproperty in the request. Instead, the deciding factor is only whether or not EIP 7702 is supported on the chain of the batch transaction.References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/4991
Changelog
Checklist