feat: Default addTransactionBatch to EIP7702 if supported, otherwise use sequential batch #5853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
b46ad98 to
6f74606
Compare
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
6f74606 to
37d55f9
Compare
matthewwalsh0
requested changes
May 23, 2025
packages/transaction-controller/src/hooks/ExtraTransactionsPublishHook.ts
Show resolved
Hide resolved
pedronfigueiredo
force-pushed
the
pnf/4991
branch
5 times, most recently
from
8808f3d to
96e2cdd
Compare
…e use sequential batch
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
96e2cdd to
cb180c9
Compare
matthewwalsh0
requested changes
May 28, 2025
packages/transaction-controller/src/hooks/ExtraTransactionsPublishHook.ts
Outdated
Show resolved
Hide resolved
pedronfigueiredo
force-pushed
the
pnf/4991
branch
from
e9419d7 to
4748992
Compare
OGPoyraz
reviewed
Jun 2, 2025
OGPoyraz
previously approved these changes
Jun 2, 2025
Co-authored-by: OGPoyraz <[email protected]>
OGPoyraz
previously approved these changes
Jun 2, 2025
matthewwalsh0
approved these changes
Jun 4, 2025
| error.message === 'Chain does not support EIP-7702' | ||
| ) { | ||
| log('Falling back to hook-based batch processing'); | ||
| return await addTransactionBatchWithHook(request); |
There was a problem hiding this comment.
Minor, could we invert the if condition to only throw if not this, then we wouldn't need to duplicate this and it would continue on below.
| @@ -401,15 +413,28 @@ async function addTransactionBatchWithHook( | |||
| getPendingTransactionTracker: request.getPendingTransactionTracker, | |||
| }); | |||
|
|
|||
| const { | |||
| request: { disable7702, disableHook, disableSequential }, | |||
There was a problem hiding this comment.
Minor, we've already got this above as userRequest.
matthewwalsh0
previously requested changes
Jun 4, 2025
| * Whether to use the publish batch hook to submit the batch. | ||
| * Defaults to false. | ||
| */ | ||
| useHook?: boolean; |
There was a problem hiding this comment.
Apologies I missed this, but this is a breaking chance since we're removing a property.
In order to avoid a breaking chance for now, and having to release all the other controllers, could we instead mark this as deprecated and clarify it will be ignored?
We could handle it as an alias for disable7702 and disableSequential but it's only used within the controller currently.
vinistevam
approved these changes
Jun 4, 2025
OGPoyraz
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We previously relied on the
useHookproperty in the request. Instead, the deciding factor is only whether or not EIP 7702 is supported on the chain of the batch transaction.References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/4991
Changelog
Checklist