Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
MetaMask
/
core
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
308
Star
413
Code
Issues
325
Pull requests
340
Actions
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Security and quality
Insights
refactor: migrate PhishingController data fetching to PhishingDataService
- #9914
#9914
Open
0xOhm
wants to merge 44 commits into
main
MetaMask/core:main
from
refactor/psafe-593-phishing-data-service
MetaMask/core:refactor/psafe-593-phishing-data-service
Copy head branch name to clipboard
Conversation
Commits
44
(44)
Checks
Files changed
Open
refactor: migrate PhishingController data fetching to PhishingDataService
#9914
0xOhm
wants to merge 44 commits into
main
MetaMask/core:main
from
refactor/psafe-593-phishing-data-service
MetaMask/core:refactor/psafe-593-phishing-data-service
Copy head branch name to clipboard
Commits
Commits on Aug 17, 2026
refactor: migrate PhishingController data fetching to PhishingDataService
Show description for 4758e65
0xOhm
and
claude
committed
4758e65
View commit details
Copy full SHA for 4758e65
Browse repository at this point
Commits on Aug 26, 2026
Merge branch 'main' into refactor/psafe-593-phishing-data-service
Show description for 5b293ee
0xOhm
committed
5b293ee
View commit details
Copy full SHA for 5b293ee
Browse repository at this point
Commits on Aug 28, 2026
chore: update generated README and formatting
adonesky1
committed
236ea8e
View commit details
Copy full SHA for 236ea8e
Browse repository at this point
Commits on Sep 1, 2026
Merge origin/main into refactor/psafe-593-phishing-data-service
adonesky1
committed
1113eae
View commit details
Copy full SHA for 1113eae
Browse repository at this point
chore: link phishing-controller changelog entries to #9914
adonesky1
committed
67a3fa8
View commit details
Copy full SHA for 67a3fa8
Browse repository at this point
fix: address review findings in PhishingDataService
Show description for 83d1c23
adonesky1
committed
83d1c23
View commit details
Copy full SHA for 83d1c23
Browse repository at this point
chore: apply oxfmt formatting
adonesky1
committed
8987113
View commit details
Copy full SHA for 8987113
Browse repository at this point
fix: validate inside the query function rather than via responseStruct
Show description for 1cf7cc7
adonesky1
committed
1cf7cc7
View commit details
Copy full SHA for 1cf7cc7
Browse repository at this point
Commits on Sep 9, 2026
Merge remote-tracking branch 'origin/main' into refactor/psafe-593-phishing-data-service
Show description for a4c6746
adonesky1
committed
a4c6746
View commit details
Copy full SHA for a4c6746
Browse repository at this point
fix: preserve successful bulk token scans
adonesky1
committed
68646de
View commit details
Copy full SHA for 68646de
Browse repository at this point
fix: abort timed-out phishing requests
adonesky1
committed
e4df833
View commit details
Copy full SHA for e4df833
Browse repository at this point
fix: validate phishing API response fields
adonesky1
committed
a465286
View commit details
Copy full SHA for a465286
Browse repository at this point
fix: wait for data service cache initialization
adonesky1
committed
90db8dc
View commit details
Copy full SHA for 90db8dc
Browse repository at this point
fix: bound rehydrated phishing query lifetime
adonesky1
committed
87d127c
View commit details
Copy full SHA for 87d127c
Browse repository at this point
test: remove obsolete phishing cache state
adonesky1
committed
7c1c20c
View commit details
Copy full SHA for 7c1c20c
Browse repository at this point
docs: update data service changelogs
adonesky1
committed
b23238a
View commit details
Copy full SHA for b23238a
Browse repository at this point
test: avoid leaking timed-out HTTP requests
adonesky1
committed
3478d00
View commit details
Copy full SHA for 3478d00
Browse repository at this point
fix: preserve uninitialized query timing
adonesky1
committed
a8bfc6b
View commit details
Copy full SHA for a8bfc6b
Browse repository at this point
fix: enforce phishing query retention bound
adonesky1
committed
176dd21
View commit details
Copy full SHA for 176dd21
Browse repository at this point
fix: tighten phishing response discriminants
adonesky1
committed
0054126
View commit details
Copy full SHA for 0054126
Browse repository at this point
fix: cancel pending phishing list requests
adonesky1
committed
a5bd89a
View commit details
Copy full SHA for a5bd89a
Browse repository at this point
test: cover initialized infinite queries
adonesky1
committed
a905f5c
View commit details
Copy full SHA for a905f5c
Browse repository at this point
fix: accept documented security alert verdicts
adonesky1
committed
4a8f8e1
View commit details
Copy full SHA for 4a8f8e1
Browse repository at this point
fix: avoid caching URL scan fetch errors
adonesky1
committed
97d0161
View commit details
Copy full SHA for 97d0161
Browse repository at this point
Commits on Sep 10, 2026
fix: abort requests when phishing service is destroyed
adonesky1
committed
21f97dd
View commit details
Copy full SHA for 21f97dd
Browse repository at this point
fix: apply service policy to approval requests
adonesky1
committed
e9242e8
View commit details
Copy full SHA for e9242e8
Browse repository at this point
fix: enforce phishing service return contracts
adonesky1
committed
53df4e3
View commit details
Copy full SHA for 53df4e3
Browse repository at this point
fix: bound data service cache rehydration and validate persisted caches
Show description for dec0fb7
adonesky1
and
claude
committed
dec0fb7
View commit details
Copy full SHA for dec0fb7
Browse repository at this point
fix: ignore hotlist diffs for unrecognized list types
Show description for 723029d
adonesky1
and
claude
committed
723029d
View commit details
Copy full SHA for 723029d
Browse repository at this point
fix: validate phishing responses per entry instead of per response
Show description for 9acaa9f
adonesky1
and
claude
committed
9acaa9f
View commit details
Copy full SHA for 9acaa9f
Browse repository at this point
fix: start data service queries synchronously when init was not called
Show description for acd27f1
adonesky1
and
claude
committed
acd27f1
View commit details
Copy full SHA for acd27f1
Browse repository at this point
fix: normalize EVM addresses in phishing scan requests and cache keys
Show description for d4c0676
adonesky1
and
claude
committed
d4c0676
View commit details
Copy full SHA for d4c0676
Browse repository at this point
fix: retry batched phishing requests as a whole and validate rehydrated scan results
Show description for 62f02d1
adonesky1
and
claude
committed
62f02d1
View commit details
Copy full SHA for 62f02d1
Browse repository at this point
docs: describe phishing data service validation and retry changes
Show description for a9d3e6d
adonesky1
and
claude
committed
a9d3e6d
View commit details
Copy full SHA for a9d3e6d
Browse repository at this point
Commits on Sep 11, 2026
refactor: fetch approvals through the query cache and drop redundant response casts
Show description for d04bcaa
adonesky1
and
claude
committed
d04bcaa
View commit details
Copy full SHA for d04bcaa
Browse repository at this point
docs: consolidate the phishing-controller changelog
Show description for 337bbda
adonesky1
and
claude
committed
337bbda
View commit details
Copy full SHA for 337bbda
Browse repository at this point
Merge remote-tracking branch 'origin/main' into pr9914-review-fixes
Show description for 81378d3
adonesky1
committed
81378d3
View commit details
Copy full SHA for 81378d3
Browse repository at this point
refactor: expose the data service policy instead of wrapping execute
Show description for 2c421e3
adonesky1
and
claude
committed
2c421e3
View commit details
Copy full SHA for 2c421e3
Browse repository at this point
docs: explain the per-request abort controller in PhishingDataService
Show description for 8d5a1c9
adonesky1
and
claude
committed
8d5a1c9
View commit details
Copy full SHA for 8d5a1c9
Browse repository at this point
refactor: batch scan lookups with a single deferred flush
Show description for c6bd755
adonesky1
and
claude
committed
c6bd755
View commit details
Copy full SHA for c6bd755
Browse repository at this point
fix: share the bounded rehydration wait across queries
Show description for 5f89fc1
adonesky1
and
claude
committed
5f89fc1
View commit details
Copy full SHA for 5f89fc1
Browse repository at this point
docs: note that batched requests carry no per-query abort signal
Show description for cff89ad
adonesky1
and
claude
committed
cff89ad
View commit details
Copy full SHA for cff89ad
Browse repository at this point
Commits on Sep 14, 2026
Merge remote-tracking branch 'origin/main' into refactor/psafe-593-phishing-data-service
adonesky1
committed
dfa5fd2
View commit details
Copy full SHA for dfa5fd2
Browse repository at this point
fix: add phishing-controller TypeScript project reference for utils
Show description for c0b3196
adonesky1
committed
c0b3196
View commit details
Copy full SHA for c0b3196
Browse repository at this point
You can’t perform that action at this time.