feat(solana-wallet-snap): route asset reads through Core when migration is on - #123
Draft
ulissesferreira wants to merge 3 commits into
Conversation
4 tasks
cursor
Bot
force-pushed
the
ulissesferreira/wpn-1476-migrate-solana-assets-controller-6620
branch
from
August 14, 2026 15:50
10ba0a6 to
116e8da
Compare
…on is on Pass RemoteFeatureFlagsProvider into AssetsService and route getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope, getAccountAssets, fetch, and saveMany through CoreAssetsAdapter when the Solana assets migration flag is active. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
…tion is on Route reads through CoreAssetsAdapter when the Solana assets flag is active. Fetch and save are no-ops because Solana has no snap-owned assets. KeyringAccountMonitor still discovers transactions but no longer persists balances from websocket notifications. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
cursor
Bot
force-pushed
the
ulissesferreira/wpn-1476-migrate-solana-assets-controller-6620
branch
from
August 14, 2026 16:16
116e8da to
feeef1d
Compare
…t shasum Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Part of migrating the Solana assets-controller staged migration into this monorepo (PR 4 of 6). Follows the Tron WPN-1497 routing approach from #145: a thin
ifinAssetsServicerather than inlining AssetsProvider calls.Solana is simpler than Tron: there are no snap-owned assets, so the flag-on path does not fetch, persist, or publish leftover Snap balances, and does not monitor addresses for snap-owned changes.
RemoteFeatureFlagsProviderintoAssetsServiceand resolve the Solana assets migration flag via#shouldReturnAssetsFromCore/isUsingCoreAssetsgetAccountAssetByID,getAccountAssetsByIDs,getAccountAssetsByScope, andgetAccountAssetsthroughCoreAssetsAdapterwhen migration is activefetchreturns[]andsaveManyis a no-op (Core already tracks fungibles)KeyringAccountMonitorstill discovers receive transactions over websockets, but skips balance persistence when the flag is onSnapAssetsAdapterAssetsServicestays a thin facadeReferences
#124)Checklist