overlay.default update #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akatori-Design
assigned Akatori-Design, georgewrmarshall and brianacnguyen and unassigned Akatori-Design
Akatori-Design
requested review from
georgewrmarshall
and removed request for
georgewrmarshall
|
BEFORE AFTER |
|
Updated overlay.default as below. This improvement enhances the distinction of modal/bottom sheet from the background layer in dark mode, and also keeps light mode consistent with the dark mode.
lightTheme :
From "value": "#66",
To "value": "#3F434A4D",
darkTheme :
From "value": "#66",
To "value": "#3F434A80",
In lightTheme, updated wrong background colors to correct : Update to these colors - muted-hover : #e7ebee --> #EBEDF1 muted-pressed : #ebecef --> #E1E4EA alternative-hover : #e7ebee --> #EBEDF1 alternative-pressed : #ebecef --> #E1E4EA
georgewrmarshall
force-pushed
the
minor-color-adjustments
branch
from
a5b0888 to
46a1778
Compare
Comment on lines
+44
to
+45
| /* Default color for overlays (scrim) (#3f434a99) */ | ||
| --color-overlay-default: #3f434a99; |
| /* Default color for overlays (scrim) (black-40%) */ | ||
| --color-overlay-default: #00000066; | ||
| /* Default color for overlays (scrim) (#3f434a66) */ | ||
| --color-overlay-default: #3f434a66; |
Comment on lines
+17
to
+24
| /* Hover state surface for background/alternative (#ebedf1) */ | ||
| --color-background-alternative-hover: #ebedf1; | ||
| /* Pressed state surface for background/alternative (#e1e4ea) */ | ||
| --color-background-alternative-pressed: #e1e4ea; | ||
| /* Hover state surface for background/muted (#ebedf1) */ | ||
| --color-background-muted-hover: #ebedf1; | ||
| /* Pressed state surface for background/muted (#e1e4ea) */ | ||
| --color-background-muted-pressed: #e1e4ea; |
| @@ -123,7 +123,7 @@ | |||
| }, | |||
| "overlay": { | |||
| "default": { | |||
| "value": "#00000066", | |||
| "value": "#3f434a99", | |||
Comment on lines
+34
to
+52
| "value": "#ebedf1", | ||
| "type": "color", | ||
| "parent": "Theme Colors/Light mode", | ||
| "description": "Hover state surface for background/alternative." | ||
| }, | ||
| "alternative-pressed": { | ||
| "value": "#ebecef", | ||
| "value": "#e1e4ea", | ||
| "type": "color", | ||
| "parent": "Theme Colors/Light mode", | ||
| "description": "Pressed state surface for background/alternative." | ||
| }, | ||
| "muted-hover": { | ||
| "value": "#e7ebee", | ||
| "value": "#ebedf1", | ||
| "type": "color", | ||
| "parent": "Theme Colors/Light mode", | ||
| "description": "Hover state surface for background/muted." | ||
| }, | ||
| "muted-pressed": { | ||
| "value": "#ebecef", | ||
| "value": "#e1e4ea", |
| @@ -123,7 +123,7 @@ | |||
| }, | |||
| "overlay": { | |||
| "default": { | |||
| "value": "#00000066", | |||
| "value": "#3f434a66", | |||
Comment on lines
+52
to
+53
| /** Default color for overlays (scrim) (#3f434a99) */ | ||
| default: '#3f434a99', |
Comment on lines
+16
to
+23
| /** Hover state surface for background/alternative (#ebedf1) */ | ||
| alternativeHover: '#ebedf1', | ||
| /** Pressed state surface for background/alternative (#e1e4ea) */ | ||
| alternativePressed: '#e1e4ea', | ||
| /** Hover state surface for background/muted (#ebedf1) */ | ||
| mutedHover: '#ebedf1', | ||
| /** Pressed state surface for background/muted (#e1e4ea) */ | ||
| mutedPressed: '#e1e4ea', |
Comment on lines
+52
to
+53
| /** Default color for overlays (scrim) (#3f434a66) */ | ||
| default: '#3f434a66', |
|
@metamaskbot publish-preview |
brianacnguyen
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Updated
overlay.defaultas below. This improvement enhances the distinction of modal/bottom sheet from the background layer in dark mode, and also keeps light mode consistent with the dark mode.lightTheme :
overlay.default:#000000 66-->#3F434A 4DdarkTheme :
overlay.default:#000000 66-->3F434A 80--
2. Updated background color bugs in lightTheme.
background.muted-hover:#e7ebee-->#EBEDF1background.alternative-hover:#f6f6f7-->#EBEDF1background.muted-pressed:#ebecef-->#E1E4EAbackground.alterntive-pressed:#ebecef-->#E1E4EA--
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist