Skip to content

refactor: refactor network picker #59443

refactor: refactor network picker

refactor: refactor network picker #59443

Triggered via pull request February 22, 2025 22:22
Status Failure
Total duration 16m 3s
Artifacts 15

main.yml

on: pull_request
Wait for CircleCI workflow status  /  Wait for CircleCI workflow status
15m 42s
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Build storybook  /  Build storybook
2m 51s
Build storybook / Build storybook
Build beta  /  Build beta
8s
Build beta / Build beta
Matrix: Run tests / Unit tests
Matrix: Validate lavamoat policy webapp / Validate lavamoat policy webapp
Lint workflows  /  Lint workflows
7s
Lint workflows / Lint workflows
Test lint shellcheck  /  Test lint shellcheck
7s
Test lint shellcheck / Test lint shellcheck
Test lint  /  Test lint
7m 30s
Test lint / Test lint
Test lint changelog  /  Test lint changelog
1m 29s
Test lint changelog / Test lint changelog
Test lint lockfile  /  Test lint lockfile
2m 8s
Test lint lockfile / Test lint lockfile
Test yarn dedupe  /  Test yarn dedupe
1m 26s
Test yarn dedupe / Test yarn dedupe
Test deps depcheck  /  Test deps depcheck
1m 45s
Test deps depcheck / Test deps depcheck
Test storybook  /  Test storybook
8m 32s
Test storybook / Test storybook
Validate lavamoat allow scripts  /  Validate lavamoat allow scripts
1m 33s
Validate lavamoat allow scripts / Validate lavamoat allow scripts
Validate lavamoat policy build  /  Validate lavamoat policy build
2m 33s
Validate lavamoat policy build / Validate lavamoat policy build
prep-build-test-browserify
8m 12s
prep-build-test-browserify
prep-build-test-webpack
2m 21s
prep-build-test-webpack
Run tests  /  Webpack tests
1m 52s
Run tests / Webpack tests
Run tests  /  Integration tests
3m 45s
Run tests / Integration tests
Test circular deps
2m 0s
Test circular deps
Test deps audit  /  Test deps audit
1m 47s
Test deps audit / Test deps audit
Runway  /  Runway
Runway / Runway
Publish prerelease  /  Publish prerelease
Publish prerelease / Publish prerelease
Matrix: run-benchmarks / benchmarks
Run tests  /  Report coverage
1m 43s
Run tests / Report coverage
All jobs completed
0s
All jobs completed
All jobs pass
0s
All jobs pass
Log merge group failure  /  Log merge group failure
Log merge group failure / Log merge group failure
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 10 warnings
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Workflow status is 'failing'. Exiting with error.
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Process completed with exit code 1.
All jobs pass
Process completed with exit code 1.
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1265
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1286
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1306
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1390
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1406
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1429
Some tests seem to be commented
Test lint / Test lint: test/e2e/flask/solana/common-solana.ts#L91
'#fb9f18' Hex color values are not allowed. Consider using design tokens instead. For support reach out to the design system team #metamask-design-system on Slack
Test lint / Test lint: ui/components/app/alert-system/alert-modal/alert-modal.tsx#L209
React Hook "useI18nContext" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?
Test lint / Test lint: ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx#L83
React Hook useMemo has an unnecessary dependency: 'TEST_CHAINS'. Either exclude it or remove the dependency array. Outer scope values like 'TEST_CHAINS' aren't valid dependencies because mutating them doesn't re-render the component
Test lint / Test lint: ui/components/app/assets/asset-list/asset-list-control-bar/asset-list-control-bar.tsx#L109
React Hook useEffect has missing dependencies: 'allOpts', 'currentNetwork.chainId', 'dispatch', and 'tokenNetworkFilter'. Either include them or remove the dependency array

Artifacts

Produced during runtime
Name Size
benchmark-browserify-pageload
823 Bytes
benchmark-browserify-userActions
197 Bytes
benchmark-webpack-pageload
816 Bytes
benchmark-webpack-userActions
196 Bytes
coverage-integration
806 KB
coverage-unit-1
1.08 MB
coverage-unit-2
1.07 MB
coverage-unit-3
1.09 MB
coverage-unit-4
1.09 MB
coverage-unit-5
1.07 MB
coverage-unit-6
1.08 MB
coverage-webpack
14.6 KB
lcov.info
334 KB
prep-build-test-browserify
60.2 MB
prep-build-test-webpack
27.5 MB