feat: adding dapp swap banner #37389
Merged
+330
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (6 files, +306 -55)
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [5e6f263]
UI Startup Metrics (1278 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [600b599]
UI Startup Metrics (1312 ± 102 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Collaborator
Builds ready [90ad897]
UI Startup Metrics (1282 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonInfo.ts
Show resolved
Hide resolved
Collaborator
Builds ready [16e5664]
UI Startup Metrics (1286 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Nov 3, 2025
OGPoyraz
approved these changes
Nov 4, 2025
auto-merge was automatically disabled
November 4, 2025 11:08
Pull Request is not mergeable
metamaskbot
added
the
release-13.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding dapp swap banner.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6107
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-10-30.at.8.07.24.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a Uniswap-gated Dapp Swap comparison banner showing estimated savings, powered by new hook computations and supporting locale strings, with tests and styles.
DappSwapComparisonBannerwith toggle (Current vs MetaMask), savings callout, dismiss button, and threshold-based display; gated bydappSwapMetricsand originhttps://app.uniswap.org.dapp-swap-comparison-banner/index.scss.useDappSwapComparisonInfo):selectedQuoteValueDifference,gasDifference,tokenAmountDifference,destinationTokenSymbol.bestFilteredQuotetoselectedQuote; add memo/metric updates and value comparisons; integrate gas/token USD calculations.COMMAND_BYTE_SEAPORT), keep sweep, and add unwrap WETH handling; refinegetDataFromSwapand token address collection.dappSwapAdvantage,dappSwapBenefits,dappSwapQuoteDetails,dappSwapQuoteDifferencetoapp/_locales/en*.json.Written by Cursor Bugbot for commit 16e5664. This will update automatically on new commits. Configure here.