build(react-compiler): 03 - Fix formatting violations of `react-compiler/react-compiler` ESLint rule #37408

MajorLift · 2025-10-31T07:27:57Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-10-31T07:28:07Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-31T07:31:46Z

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +4 -4)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item-menu/
      - 📄 account-list-item-menu.js +0 -1
    - 📁 account-picker/
      - 📄 account-picker.js +4 -3

✅ @MetaMask/confirmations (6 files, +7 -11)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 pages/
      - 📁 send/
        
        📄 send.js +0 -1
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 info/
        
        📁 hooks/
        
        📄 useDecodedTransactionData.ts +2 -2
        
        📄 useFourByte.ts +2 -2
        
        📄 useNestedTransactionLabels.ts +1 -1
      - 📁 simulation-error-message/
        
        📄 simulation-error-message.js +0 -1
    - 📁 confirm-transaction/
      - 📄 confirm-transaction.component.js +2 -4

👨‍🔧 @MetaMask/core-extension-ux (4 files, +11 -13)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 account-list-item-menu/
      - 📄 account-list-item-menu.js +0 -1
    - 📁 account-picker/
      - 📄 account-picker.js +4 -3
    - 📁 notification-detail-network-fee/
      - 📄 notification-detail-network-fee.tsx +7 -8
    - 📁 pages/
      - 📁 send/
        
        📄 send.js +0 -1

💎 @MetaMask/metamask-assets (2 files, +2 -4)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 token-cell/
        
        📄 token-cell.test.tsx +2 -2
      - 📁 token-list/
        
        📄 token-list.tsx +0 -2

🔔 @MetaMask/notifications (1 files, +7 -8)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 notification-detail-network-fee/
      - 📄 notification-detail-network-fee.tsx +7 -8

🔄 @MetaMask/swaps-engineers (2 files, +12 -7)

📁 ui/
- 📁 pages/
  - 📁 bridge/
    - 📁 awaiting-signatures/
      - 📄 awaiting-signatures.tsx +0 -1
    - 📁 prepare/
      - 📄 prepare-bridge-page.tsx +12 -6

metamaskbot · 2025-10-31T07:56:10Z

📊 Page Load Benchmark Results

Current Commit: e2d16d8 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±76ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±74ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±33ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	76ms	1.02s	1.56s	1.26s	1.56s
domContentLoaded	737ms	74ms	704ms	1.23s	934ms	1.23s
firstPaint	79ms	33ms	56ms	396ms	92ms	396ms
firstContentfulPaint	79ms	33ms	56ms	396ms	92ms	396ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-31T07:56:27Z

Builds ready [e2d16d8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- content-script: 0
- offscreen: 0

UI Startup Metrics (1313 ± 100 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1313	1115	1547	100	1392	1481
			load	1137	943	1367	100	1218	1319
			domContentLoaded	1129	938	1358	100	1212	1314
			domInteractive	21	15	74	10	20	49
			firstPaint	538	86	1366	449	1077	1246
			backgroundConnect	233	213	334	12	237	247
			firstReactRender	30	18	104	10	33	45
			getState	18	8	43	7	22	33
			initialActions	5	1	15	3	6	12
			loadScripts	904	712	1137	101	991	1087
			setupStore	10	6	30	3	11	13
			numNetworkReqs	8	6	26	5	6	24
	Browserify	Power User Home	uiStartup	2316	1845	4156	728	3189	4156
			load	1165	947	1829	308	1601	1829
			domContentLoaded	1157	938	1817	306	1591	1817
			domInteractive	32	16	125	27	42	125
			firstPaint	446	196	1010	312	942	1010
			backgroundConnect	327	221	1023	216	304	1023
			firstReactRender	27	25	36	3	28	36
			getState	185	163	288	35	184	288
			initialActions	5	2	14	3	7	14
			loadScripts	901	717	1381	249	1242	1381
			setupStore	13	8	27	6	13	27
			numNetworkReqs	354	172	679	185	635	679
	Webpack	Standard Home	uiStartup	880	754	1163	72	902	1037
			load	651	605	912	61	661	844
			domContentLoaded	644	599	902	61	654	827
			domInteractive	16	12	61	9	15	43
			firstPaint	217	59	905	207	210	718
			backgroundConnect	25	13	60	8	29	43
			firstReactRender	29	18	70	9	34	37
			getState	12	6	21	4	15	18
			initialActions	3	0	14	2	4	7
			loadScripts	640	597	890	59	652	816
			setupStore	11	5	23	3	13	16
			numNetworkReqs	8	6	29	6	6	27
	Webpack	Power User Home	uiStartup	1685	1262	2681	420	2186	2681
			load	731	624	1095	141	879	1095
			domContentLoaded	693	611	996	105	791	996
			domInteractive	18	13	33	7	21	33
			firstPaint	422	83	1096	339	794	1096
			backgroundConnect	135	12	477	167	375	477
			firstReactRender	25	22	30	2	26	30
			getState	162	149	230	20	164	230
			initialActions	7	1	57	14	6	57
			loadScripts	688	609	985	102	780	985
			setupStore	19	6	74	18	27	74
			numNetworkReqs	345	193	702	173	557	702
Firefox	Browserify	Standard Home	uiStartup	1501	1311	1875	101	1563	1678
			load	1286	1134	1505	78	1333	1427
			domContentLoaded	1286	1134	1504	78	1332	1427
			domInteractive	115	36	332	42	130	207
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	21	140	19	49	74
			firstReactRender	27	22	55	7	27	49
			getState	8	4	48	5	9	12
			initialActions	4	1	89	10	3	7
			loadScripts	1260	1114	1476	75	1311	1399
			setupStore	13	8	59	7	13	27
			numNetworkReqs	8	6	27	5	7	24
	Browserify	Power User Home	uiStartup	3058	2440	4462	633	3391	4462
			load	1588	1350	1960	217	1828	1960
			domContentLoaded	1588	1349	1960	217	1827	1960
			domInteractive	191	104	363	82	264	363
			firstPaint	-	-	-	-	-	-
			backgroundConnect	311	44	1255	339	553	1255
			firstReactRender	49	36	108	17	54	108
			getState	153	94	277	42	180	277
			initialActions	32	2	344	82	12	344
			loadScripts	1504	1319	1798	164	1661	1798
			setupStore	36	7	134	39	45	134
			numNetworkReqs	285	162	497	103	347	497
	Webpack	Standard Home	uiStartup	1630	1448	2042	128	1648	1958
			load	1385	1240	1773	89	1413	1555
			domContentLoaded	1385	1240	1773	89	1413	1555
			domInteractive	113	31	393	65	119	293
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	25	84	14	53	71
			firstReactRender	31	23	89	12	30	65
			getState	8	4	45	5	10	15
			initialActions	7	1	173	19	4	38
			loadScripts	1357	1221	1749	88	1388	1524
			setupStore	21	6	201	37	14	75
			numNetworkReqs	8	6	30	6	7	25
	Webpack	Power User Home	uiStartup	2701	2237	3591	411	2889	3591
			load	1589	1282	1989	226	1807	1989
			domContentLoaded	1589	1282	1989	226	1807	1989
			domInteractive	130	70	279	58	181	279
			firstPaint	-	-	-	-	-	-
			backgroundConnect	162	31	752	218	113	752
			firstReactRender	44	31	99	16	48	99
			getState	142	81	320	56	184	320
			initialActions	5	1	16	5	7	16
			loadScripts	1542	1252	1866	206	1765	1866
			setupStore	21	8	56	14	30	56
			numNetworkReqs	258	132	536	118	303	536

metamaskbot · 2025-10-31T16:23:01Z

📊 Page Load Benchmark Results

Current Commit: 7c522df | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 717ms (±35ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	999ms	1.30s	1.08s	1.30s
domContentLoaded	717ms	35ms	691ms	970ms	756ms	970ms
firstPaint	76ms	13ms	60ms	184ms	84ms	184ms
firstContentfulPaint	76ms	13ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-31T16:23:07Z

Builds ready [7c522df]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- content-script: 0
- offscreen: 0

UI Startup Metrics (1343 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1343	1127	1576	110	1426	1500
			load	1160	933	1365	112	1252	1339
			domContentLoaded	1153	927	1358	111	1244	1331
			domInteractive	20	15	52	7	21	43
			firstPaint	527	88	1315	434	1089	1282
			backgroundConnect	234	222	250	6	237	245
			firstReactRender	32	19	168	19	37	45
			getState	19	9	42	7	21	32
			initialActions	7	1	45	8	8	27
			loadScripts	927	696	1136	111	1015	1107
			setupStore	11	7	26	3	12	16
			numNetworkReqs	8	6	24	5	6	24
	Browserify	Power User Home	uiStartup	2106	1788	3154	442	2650	3154
			load	1127	933	1649	285	1576	1649
			domContentLoaded	1118	928	1632	283	1565	1632
			domInteractive	24	15	52	12	36	52
			firstPaint	768	97	1635	525	1011	1635
			backgroundConnect	264	216	429	64	319	429
			firstReactRender	26	23	34	3	29	34
			getState	168	121	242	24	173	242
			initialActions	8	2	65	15	5	65
			loadScripts	881	704	1355	253	1278	1355
			setupStore	11	8	31	5	11	31
			numNetworkReqs	336	203	695	201	676	695
	Webpack	Standard Home	uiStartup	877	757	1109	61	899	1019
			load	649	603	916	56	663	800
			domContentLoaded	641	596	895	55	656	792
			domInteractive	16	12	47	7	15	42
			firstPaint	220	60	899	221	199	781
			backgroundConnect	25	13	72	9	28	47
			firstReactRender	29	17	121	12	34	37
			getState	13	6	35	4	15	18
			initialActions	4	0	14	3	5	9
			loadScripts	638	594	885	52	653	781
			setupStore	10	6	19	3	13	15
			numNetworkReqs	8	6	29	6	6	27
	Webpack	Power User Home	uiStartup	1745	1331	2609	413	2016	2609
			load	770	650	1150	169	900	1150
			domContentLoaded	717	636	950	105	865	950
			domInteractive	21	14	50	10	28	50
			firstPaint	474	81	1013	361	902	1013
			backgroundConnect	134	20	525	185	129	525
			firstReactRender	27	22	45	5	27	45
			getState	155	97	169	17	164	169
			initialActions	14	1	171	41	7	171
			loadScripts	713	634	939	102	853	939
			setupStore	12	6	33	9	18	33
			numNetworkReqs	337	198	727	186	583	727
Firefox	Browserify	Standard Home	uiStartup	1464	1306	1837	84	1509	1606
			load	1262	1146	1428	62	1308	1369
			domContentLoaded	1262	1146	1428	62	1307	1369
			domInteractive	110	38	275	41	120	209
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	26	111	16	49	75
			firstReactRender	26	20	51	6	26	42
			getState	7	3	40	5	8	14
			initialActions	4	1	75	9	3	7
			loadScripts	1237	1128	1367	58	1282	1342
			setupStore	13	7	99	9	14	16
			numNetworkReqs	8	6	27	6	7	25
	Browserify	Power User Home	uiStartup	2605	2190	3507	329	2837	3507
			load	1416	1253	1747	146	1503	1747
			domContentLoaded	1416	1252	1746	146	1503	1746
			domInteractive	149	98	256	48	186	256
			firstPaint	-	-	-	-	-	-
			backgroundConnect	156	32	386	118	253	386
			firstReactRender	43	30	64	10	51	64
			getState	143	36	338	62	173	338
			initialActions	11	1	52	14	16	52
			loadScripts	1367	1217	1705	136	1459	1705
			setupStore	31	6	66	20	54	66
			numNetworkReqs	243	144	369	66	306	369
	Webpack	Standard Home	uiStartup	1694	1443	2406	181	1779	2016
			load	1455	1234	1930	148	1542	1784
			domContentLoaded	1454	1233	1930	148	1542	1784
			domInteractive	120	33	579	93	115	245
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	26	142	20	54	86
			firstReactRender	31	23	98	13	30	64
			getState	11	5	142	16	10	39
			initialActions	6	1	174	19	3	13
			loadScripts	1424	1212	1884	146	1514	1750
			setupStore	13	7	108	11	13	20
			numNetworkReqs	8	6	32	6	7	27
	Webpack	Power User Home	uiStartup	2961	2461	3728	421	3321	3728
			load	1679	1396	2120	208	1847	2120
			domContentLoaded	1678	1395	2120	208	1847	2120
			domInteractive	149	62	337	68	177	337
			firstPaint	-	-	-	-	-	-
			backgroundConnect	210	39	673	177	260	673
			firstReactRender	50	32	83	15	55	83
			getState	164	70	264	50	201	264
			initialActions	10	2	63	14	13	63
			loadScripts	1623	1370	2047	188	1772	2047
			setupStore	30	9	121	27	40	121
			numNetworkReqs	263	157	468	107	383	468

metamaskbot · 2025-11-03T12:39:31Z

Builds ready [c6f72fe]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- content-script: 0
- offscreen: 0

UI Startup Metrics (1290 ± 98 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1290	1101	1651	98	1349	1480
			load	1111	961	1370	86	1174	1247
			domContentLoaded	1105	956	1364	85	1168	1237
			domInteractive	22	14	75	13	21	58
			firstPaint	706	147	1323	452	1150	1243
			backgroundConnect	232	218	255	6	235	245
			firstReactRender	30	19	56	7	35	43
			getState	20	9	63	8	23	33
			initialActions	9	1	78	14	7	51
			loadScripts	880	735	1122	83	940	1012
			setupStore	11	7	36	3	11	16
			numNetworkReqs	13	6	76	20	6	70
	Browserify	Power User Home	uiStartup	2024	1802	2776	357	2278	2776
			load	1056	918	1550	211	1294	1550
			domContentLoaded	1046	911	1539	212	1285	1539
			domInteractive	25	15	56	14	45	56
			firstPaint	685	177	1582	478	936	1582
			backgroundConnect	240	217	281	18	254	281
			firstReactRender	29	25	59	8	28	59
			getState	178	158	197	13	191	197
			initialActions	5	3	13	3	6	13
			loadScripts	821	688	1285	201	1057	1285
			setupStore	12	9	25	5	11	25
			numNetworkReqs	157	102	317	89	308	317
	Webpack	Standard Home	uiStartup	860	727	1259	103	858	1125
			load	648	587	997	92	648	903
			domContentLoaded	640	582	978	89	642	890
			domInteractive	16	11	63	9	14	40
			firstPaint	209	56	987	206	197	690
			backgroundConnect	25	11	100	16	27	60
			firstReactRender	27	17	50	8	33	36
			getState	12	5	28	4	14	17
			initialActions	3	0	15	3	4	7
			loadScripts	637	580	968	87	640	878
			setupStore	11	5	32	5	12	20
			numNetworkReqs	13	6	76	19	7	70
	Webpack	Power User Home	uiStartup	1340	1169	1919	258	1584	1919
			load	674	596	1011	115	758	1011
			domContentLoaded	658	587	970	105	726	970
			domInteractive	24	12	89	21	39	89
			firstPaint	296	72	973	245	591	973
			backgroundConnect	65	11	226	71	86	226
			firstReactRender	26	24	29	1	26	29
			getState	140	97	160	19	152	160
			initialActions	4	0	27	7	3	27
			loadScripts	654	585	959	102	714	959
			setupStore	18	6	136	31	21	136
			numNetworkReqs	148	97	281	69	198	281
Firefox	Browserify	Standard Home	uiStartup	1486	1279	1971	122	1554	1705
			load	1269	1093	1443	84	1334	1418
			domContentLoaded	1269	1092	1443	84	1333	1418
			domInteractive	114	36	305	40	129	194
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	20	189	26	49	112
			firstReactRender	26	21	59	6	26	40
			getState	8	4	32	5	9	15
			initialActions	4	1	34	5	4	14
			loadScripts	1239	1075	1408	78	1302	1370
			setupStore	17	7	217	28	11	42
			numNetworkReqs	13	6	68	16	7	61
	Browserify	Power User Home	uiStartup	2490	2197	3414	314	2586	3414
			load	1381	1149	1943	195	1542	1943
			domContentLoaded	1380	1149	1942	194	1542	1942
			domInteractive	216	95	553	153	352	553
			firstPaint	-	-	-	-	-	-
			backgroundConnect	113	31	470	111	172	470
			firstReactRender	37	30	55	7	40	55
			getState	127	36	190	37	157	190
			initialActions	12	2	81	20	15	81
			loadScripts	1341	1128	1879	188	1492	1879
			setupStore	43	6	264	62	69	264
			numNetworkReqs	132	68	331	74	177	331
	Webpack	Standard Home	uiStartup	1639	1403	2416	162	1673	1931
			load	1390	1220	1784	112	1422	1623
			domContentLoaded	1390	1219	1784	112	1422	1622
			domInteractive	99	32	344	38	114	156
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	23	158	25	55	114
			firstReactRender	34	23	88	16	33	77
			getState	8	5	21	3	8	14
			initialActions	7	1	223	22	5	15
			loadScripts	1361	1202	1662	102	1393	1599
			setupStore	16	7	82	13	14	49
			numNetworkReqs	13	6	70	17	7	64
	Webpack	Power User Home	uiStartup	2565	2156	3296	336	2697	3296
			load	1542	1245	2041	217	1743	2041
			domContentLoaded	1542	1244	2041	217	1743	2041
			domInteractive	221	76	618	174	392	618
			firstPaint	-	-	-	-	-	-
			backgroundConnect	76	25	225	52	113	225
			firstReactRender	42	31	52	7	49	52
			getState	157	91	230	47	201	230
			initialActions	19	1	183	43	18	183
			loadScripts	1514	1225	2007	215	1707	2007
			setupStore	30	6	155	40	32	155
			numNetworkReqs	137	65	320	89	211	320

📊 Page Load Benchmark Results

Current Commit: c6f72fe | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±62ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±59ms) 🟢 | historical mean value: 729ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	62ms	1.02s	1.32s	1.25s	1.32s
domContentLoaded	733ms	59ms	703ms	1000ms	924ms	1000ms
firstPaint	77ms	13ms	60ms	184ms	92ms	184ms
firstContentfulPaint	77ms	13ms	60ms	184ms	92ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

…Validation`

…to it not being recognized as returning an inline function reference React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

metamaskbot · 2025-11-03T18:15:29Z

Builds ready [891ad0e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17
- content-script: 0
- offscreen: 0

UI Startup Metrics (1297 ± 98 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1297	1119	1744	98	1356	1441
			load	1118	950	1493	87	1182	1229
			domContentLoaded	1112	945	1483	86	1174	1222
			domInteractive	21	14	81	12	20	47
			firstPaint	632	88	1524	449	1120	1220
			backgroundConnect	230	218	253	7	236	246
			firstReactRender	30	20	58	8	36	45
			getState	22	9	50	8	26	38
			initialActions	7	1	81	12	7	21
			loadScripts	887	731	1254	85	951	1005
			setupStore	11	6	29	4	12	23
			numNetworkReqs	13	6	76	20	6	71
	Browserify	Power User Home	uiStartup	1992	1727	3405	475	2278	3405
			load	1027	865	1778	250	1250	1778
			domContentLoaded	1016	858	1727	240	1242	1727
			domInteractive	33	15	132	31	50	132
			firstPaint	865	219	1778	430	1254	1778
			backgroundConnect	215	184	388	47	223	388
			firstReactRender	27	25	32	2	28	32
			getState	174	144	243	26	191	243
			initialActions	5	2	16	3	6	16
			loadScripts	815	674	1380	207	1028	1380
			setupStore	16	9	26	7	25	26
			numNetworkReqs	156	103	310	85	287	310
	Webpack	Standard Home	uiStartup	880	742	1507	104	890	1115
			load	664	593	1310	101	664	880
			domContentLoaded	654	586	1259	96	657	867
			domInteractive	15	11	54	8	14	36
			firstPaint	223	60	1309	223	200	775
			backgroundConnect	27	12	85	16	27	74
			firstReactRender	28	17	63	9	34	41
			getState	12	7	20	3	14	18
			initialActions	4	0	33	4	5	9
			loadScripts	651	584	1248	94	655	856
			setupStore	10	5	22	3	12	17
			numNetworkReqs	13	6	78	20	8	71
	Webpack	Power User Home	uiStartup	1380	1221	1915	218	1566	1915
			load	703	628	964	100	783	964
			domContentLoaded	685	615	934	95	764	934
			domInteractive	24	13	80	20	38	80
			firstPaint	365	75	838	250	623	838
			backgroundConnect	73	21	233	73	59	233
			firstReactRender	30	26	67	10	28	67
			getState	149	85	189	23	161	189
			initialActions	4	1	30	7	2	30
			loadScripts	680	613	923	92	751	923
			setupStore	10	6	25	6	10	25
			numNetworkReqs	144	98	277	64	198	277
Firefox	Browserify	Standard Home	uiStartup	1533	1340	1824	107	1591	1754
			load	1309	1144	1549	87	1376	1483
			domContentLoaded	1309	1144	1549	87	1376	1482
			domInteractive	119	36	397	54	130	217
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	24	120	17	50	85
			firstReactRender	27	22	52	5	27	34
			getState	8	4	64	6	8	14
			initialActions	4	1	21	3	4	13
			loadScripts	1282	1128	1537	85	1344	1451
			setupStore	14	7	83	10	13	32
			numNetworkReqs	12	6	66	16	7	59
	Browserify	Power User Home	uiStartup	2525	2258	3069	225	2741	3069
			load	1468	1257	2167	265	1669	2167
			domContentLoaded	1468	1256	2167	265	1669	2167
			domInteractive	245	91	666	208	494	666
			firstPaint	-	-	-	-	-	-
			backgroundConnect	105	36	292	84	149	292
			firstReactRender	40	33	55	7	48	55
			getState	136	78	195	30	154	195
			initialActions	6	1	19	5	9	19
			loadScripts	1424	1180	2102	253	1633	2102
			setupStore	31	5	122	31	58	122
			numNetworkReqs	136	71	311	74	209	311
	Webpack	Standard Home	uiStartup	1632	1422	2092	143	1680	1964
			load	1383	1206	1692	99	1435	1602
			domContentLoaded	1383	1206	1692	99	1435	1602
			domInteractive	95	33	238	30	102	158
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	21	170	28	53	125
			firstReactRender	32	23	76	13	32	73
			getState	10	4	68	11	10	46
			initialActions	7	1	179	18	4	24
			loadScripts	1353	1188	1615	89	1406	1534
			setupStore	18	7	193	27	14	71
			numNetworkReqs	13	6	70	17	8	65
	Webpack	Power User Home	uiStartup	2546	2145	2950	262	2881	2950
			load	1517	1200	1874	198	1710	1874
			domContentLoaded	1517	1199	1873	198	1709	1873
			domInteractive	184	63	515	143	375	515
			firstPaint	-	-	-	-	-	-
			backgroundConnect	76	30	212	46	101	212
			firstReactRender	44	30	74	12	52	74
			getState	143	78	234	44	198	234
			initialActions	17	1	76	24	21	76
			loadScripts	1490	1178	1832	194	1679	1832
			setupStore	31	10	95	25	49	95
			numNetworkReqs	136	67	305	76	198	305

📊 Page Load Benchmark Results

Current Commit: 891ad0e | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±38ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 729ms (±36ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	38ms	1.02s	1.32s	1.10s	1.32s
domContentLoaded	729ms	36ms	706ms	997ms	765ms	997ms
firstPaint	77ms	10ms	60ms	164ms	88ms	164ms
firstContentfulPaint	77ms	10ms	60ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

metamaskbot added the team-extension-platform Extension Platform team label Oct 31, 2025

MajorLift force-pushed the jongsun/build/251031-fix-react-compiler-formatting-violations branch from fcc683e to e2d16d8 Compare October 31, 2025 07:28

github-actions bot added the size-L label Oct 31, 2025

MajorLift added the DO-NOT-MERGE Pull requests that should not be merged label Oct 31, 2025

MajorLift force-pushed the jongsun/build/251031-fix-react-compiler-formatting-violations branch from e2d16d8 to 61f3a98 Compare October 31, 2025 15:44

MajorLift force-pushed the jongsun/build/251030-set-up-react-compiler branch 2 times, most recently from d52ff6d to b97e785 Compare November 3, 2025 11:25

MajorLift force-pushed the jongsun/build/251031-fix-react-compiler-formatting-violations branch from 7c522df to d5291d8 Compare November 3, 2025 11:48

MajorLift force-pushed the jongsun/build/251030-set-up-react-compiler branch from 608b6ac to 2423e56 Compare November 3, 2025 12:11

MajorLift force-pushed the jongsun/build/251031-fix-react-compiler-formatting-violations branch from d5291d8 to c6f72fe Compare November 3, 2025 12:12

MajorLift force-pushed the jongsun/build/251030-set-up-react-compiler branch from 2423e56 to 27ca8a3 Compare November 3, 2025 17:48

MajorLift added 10 commits November 3, 2025 12:48

Remove eslint-disable directives for required rules

5962bc0

Rename use4ByteResolutionSelector to getUse4ByteResolution

3d509e1

Rename useSafeChainsListValidationSelector to `getUseSafeChainsList…

5734e36

…Validation`

Rename _NotificationDetailNetworkFee

c35f817

Fix proptype

20fda30

Sidestep compiler alert about useCallback wrapping debounce, due …

1eb2e41

…to it not being recognized as returning an inline function reference React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead react-hooks/exhaustive-deps

Fix null test for background[method] in test envs

cc2d4e8

Wrap hook calls in tests with renderHook

650ab9d

Rename {g,useG}etIsEstimatedReturnLow

7f5f05c

Rename internal hook in withRouterHooks with use prepend

891ad0e

MajorLift force-pushed the jongsun/build/251031-fix-react-compiler-formatting-violations branch from c6f72fe to 891ad0e Compare November 3, 2025 17:48

MajorLift mentioned this pull request Nov 3, 2025

build: Enable React Compiler for Browserify builds, fix react-compiler/react-compiler ESLint rule violations #37480

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(react-compiler): 03 - Fix formatting violations of `react-compiler/react-compiler` ESLint rule #37408

build(react-compiler): 03 - Fix formatting violations of `react-compiler/react-compiler` ESLint rule #37408

Uh oh!

MajorLift commented Oct 31, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

build(react-compiler): 03 - Fix formatting violations of react-compiler/react-compiler ESLint rule #37408

Are you sure you want to change the base?

build(react-compiler): 03 - Fix formatting violations of react-compiler/react-compiler ESLint rule #37408

Uh oh!

Conversation

MajorLift commented Oct 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 31, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

build(react-compiler): 03 - Fix formatting violations of `react-compiler/react-compiler` ESLint rule #37408

build(react-compiler): 03 - Fix formatting violations of `react-compiler/react-compiler` ESLint rule #37408

MajorLift commented Oct 31, 2025 •

edited by github-actions bot

Loading

metamaskbot commented Oct 31, 2025 •

edited

Loading