chore: Refactor to remove warnings in confirmations' `confirm.test.tsx` #37431

pedronfigueiredo · 2025-10-31T17:11:18Z

Description

Clean‑ups so the confirmation flow selectors stop tripping Reselect’s dev‑mode warnings while keeping behaviour intact:
- shared/modules/selectors/smart-transactions.ts -- Normalised the opt‑in selectors (getSmartTransactionsOptInStatusForMetrics, getSmartTransactionsPreferenceEnabled) so they return booleans/null instead of blindly echoing the stored value; this gives the combiner meaningful work and avoids the identity check complaints.
- test/jest/setup.js -- Dropped the global setGlobalDevModeChecks(...) override and replaced it with a lightweight proxy background stub. The warnings are now addressed in code rather than hidden in test setup.
- ui/pages/confirmations/hooks/useCurrentConfirmation.ts -- Replaced the stack of individual useSelector calls with a single lookup of a new aggregated selector. The hook now just reads selectConfirmationData, eliminating several pass‑through selectors that used to return the input unchanged.
- ui/pages/confirmations/selectors/confirm.ts -- Added selectConfirmationData, a memoized selector that:
  - picks the active confirmation ID (explicit route param or the oldest pending approval)
  - fetches the matching approval, transaction meta, and signature message
  - packages them into a shaped object. This concentrates the memoization logic in one place so Reselect no longer sees identity functions.
- ui/selectors/approvals.ts / ui/selectors/accounts.ts -- Wrapped getPendingApprovals, pendingApprovalsSortedSelector, and getInternalAccounts in proper memoized selectors that build their arrays in the combiner instead of returning new Object.values(...) results each time. selectPendingApproval now reuses its internal selector directly.
- ui/selectors/signatures.ts – Simplified selectUnapprovedMessage to export the existing memoized selector rather than wrapping it in another x => x layer.
- ui/selectors/selectors.js – Adjusted selectors that simply
  forwarded upstream data:
  - getMemoizedMetaMaskInternalAccounts and selectERC20TokensByChain now expose the existing selectors.
  - getUnapprovedTransaction returns a cloned transaction (or undefined) instead of the original reference.
- ui/selectors/transactions.js – Ensured every selector’s result transforms its input:
  - the base transaction lists clone before returning;
  - filtered selectors (getUnapprovedTransactions, getApprovedAndSignedTransactions, submittedPendingTransactionsSelector, etc.) build new arrays (copying items when needed);
  - removed the redundant getAllNetworkTransactions wrapper;
  - guarded empty cases explicitly so dev-mode sees a new reference rather than the unmodified input.
- ui/pages/confirmations/confirm/snapshots/confirm.test.tsx.snap – Snapshots were updated automatically to reflect the more complete render output once the selectors no longer short-circuited.

Collectively these changes mean Reselect’s dev-mode checks now recognise actual transformations—the warnings are gone because selectors either generate fresh data or expose memoized helpers directly, rather than returning the same reference they were given.

Wrapped render logic in act once and flushed pending promises
Introduce a proper background stub

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors confirmation flow and shared selectors for proper memoization/value normalization and updates tests (async render + background stub), eliminating Reselect dev warnings and refreshing snapshots.

Selectors:
- Confirmations: Add selectConfirmationData; refactor useCurrentConfirmation to use it; add pendingConfirmations* selectors; expose oldestPendingConfirmationSelector.
- Transactions: Ensure outputs clone/transform data (getTransactions, getUnapprovedTransactions, getApprovedAndSignedTransactions, submittedPendingTransactionsSelector, etc.); remove redundant wrappers; guard empty cases.
- Approvals/Accounts/Signatures: Convert to memoized selectors (getPendingApprovals, pendingApprovalsSortedSelector, getInternalAccounts); simplify selectPendingApproval/selectUnapprovedMessage.
- Shared selectors: Update getUnapprovedTransaction to return a cloned item; expose existing selectors (getMemoizedMetaMaskInternalAccounts, selectERC20TokensByChain).
- Smart Transactions: Normalize opt-in selectors to return boolean|null; keep default-enabled logic in getSmartTransactionsPreferenceEnabled.
Tests/Infra:
- Jest setup: add background connection proxy stub.
- Confirm page tests: wrap render in act, flush promises, factor renderConfirm, update snapshots.
- Hooks tests: refactor useNonContractAddressAlerts and useAutomaticGasFeeTokenSelect tests to provider-based helpers; add store update helper; stabilize mocks.
- Onboarding welcome tests: use clearAllMocks and adjust spies.

^{Written by Cursor Bugbot for commit 7f54bf7. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-31T17:11:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-31T17:14:00Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (6 files, +422 -389)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 confirm/
      - 📁 __snapshots__/
        
        📄 confirm.test.tsx.snap +150 -21
        
        📄 confirm.test.tsx +32 -70
    - 📁 hooks/
      - 📁 alerts/
        
        📁 transactions/
        
        📄 useNonContractAddressAlerts.test.ts +107 -245
        
        📄 useAutomaticGasFeeTokenSelect.test.ts +40 -10
        
        📄 useCurrentConfirmation.ts +13 -24
    - 📁 selectors/
      - 📄 confirm.ts +80 -19

🔐 @MetaMask/web3auth (1 files, +6 -5)

📁 ui/
- 📁 pages/
  - 📁 onboarding-flow/
    - 📁 welcome/
      - 📄 welcome.test.js +6 -5

metamaskbot · 2025-10-31T17:37:15Z

📊 Page Load Benchmark Results

Current Commit: e372f77 | Date: 10/31/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	39ms	1.01s	1.31s	1.07s	1.31s
domContentLoaded	720ms	36ms	698ms	978ms	738ms	978ms
firstPaint	76ms	12ms	60ms	184ms	84ms	184ms
firstContentfulPaint	76ms	12ms	60ms	184ms	84ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-31T17:37:24Z

Builds ready [e372f77]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1287 ± 92 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1287	1121	1522	92	1351	1468
			load	1109	972	1360	89	1167	1292
			domContentLoaded	1103	963	1351	88	1162	1286
			domInteractive	20	14	57	10	20	48
			firstPaint	594	74	1293	446	1117	1229
			backgroundConnect	229	218	247	6	232	240
			firstReactRender	28	17	58	8	32	45
			getState	22	9	79	10	26	40
			initialActions	6	0	28	5	6	13
			loadScripts	880	743	1124	88	937	1066
			setupStore	11	6	27	3	12	17
			numNetworkReqs	9	6	32	7	6	30
	Browserify	Power User Home	uiStartup	2107	1743	3047	489	2892	3047
			load	1152	927	1975	344	1590	1975
			domContentLoaded	1145	920	1967	343	1577	1967
			domInteractive	28	17	76	17	46	76
			firstPaint	842	195	1793	456	978	1793
			backgroundConnect	260	218	675	109	243	675
			firstReactRender	25	22	31	2	27	31
			getState	174	158	198	12	184	198
			initialActions	6	2	19	5	5	19
			loadScripts	910	707	1548	307	1330	1548
			setupStore	11	9	18	2	11	18
			numNetworkReqs	350	212	710	180	579	710
	Webpack	Standard Home	uiStartup	855	730	1126	78	874	1049
			load	646	595	928	69	652	860
			domContentLoaded	639	588	920	67	646	851
			domInteractive	15	11	45	6	14	30
			firstPaint	185	58	900	190	175	626
			backgroundConnect	23	12	52	8	26	41
			firstReactRender	27	17	61	9	32	36
			getState	13	6	29	5	14	24
			initialActions	3	1	16	3	4	9
			loadScripts	635	586	908	65	643	840
			setupStore	11	6	32	4	12	17
			numNetworkReqs	9	6	36	8	6	32
	Webpack	Power User Home	uiStartup	1717	1477	2393	345	2138	2393
			load	736	642	1080	145	793	1080
			domContentLoaded	703	618	1024	124	758	1024
			domInteractive	18	13	34	7	22	34
			firstPaint	470	115	1030	334	798	1030
			backgroundConnect	136	35	447	151	353	447
			firstReactRender	26	21	39	4	26	39
			getState	151	124	169	9	156	169
			initialActions	10	0	54	18	8	54
			loadScripts	698	616	1014	121	747	1014
			setupStore	20	6	52	15	25	52
			numNetworkReqs	341	202	688	160	552	688
Firefox	Browserify	Standard Home	uiStartup	1455	1271	1788	96	1505	1677
			load	1254	1112	1534	73	1298	1382
			domContentLoaded	1253	1112	1533	73	1298	1381
			domInteractive	113	37	297	42	126	217
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	110	16	49	75
			firstReactRender	24	21	58	5	25	39
			getState	8	4	49	7	8	14
			initialActions	3	2	8	1	4	6
			loadScripts	1227	1095	1507	71	1266	1358
			setupStore	12	7	77	8	13	19
			numNetworkReqs	9	6	33	7	8	30
	Browserify	Power User Home	uiStartup	2682	2244	4145	477	2895	4145
			load	1409	1271	1760	140	1545	1760
			domContentLoaded	1408	1270	1759	140	1545	1759
			domInteractive	172	100	320	69	225	320
			firstPaint	-	-	-	-	-	-
			backgroundConnect	204	40	1076	257	315	1076
			firstReactRender	45	30	93	15	48	93
			getState	147	73	250	39	178	250
			initialActions	6	1	12	4	11	12
			loadScripts	1359	1208	1605	120	1471	1605
			setupStore	30	6	110	28	38	110
			numNetworkReqs	264	150	594	111	330	594
	Webpack	Standard Home	uiStartup	1532	1349	2116	131	1553	1815
			load	1324	1189	1613	89	1361	1513
			domContentLoaded	1323	1189	1612	89	1361	1513
			domInteractive	102	31	313	46	110	209
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	23	111	16	49	79
			firstReactRender	27	20	69	10	28	66
			getState	9	3	81	11	8	23
			initialActions	8	1	172	26	3	11
			loadScripts	1298	1167	1584	88	1338	1480
			setupStore	12	6	55	7	12	25
			numNetworkReqs	9	6	35	7	7	31
	Webpack	Power User Home	uiStartup	2894	2303	4314	617	3167	4314
			load	1632	1347	2275	254	1792	2275
			domContentLoaded	1631	1347	2274	254	1791	2274
			domInteractive	127	44	291	63	157	291
			firstPaint	-	-	-	-	-	-
			backgroundConnect	221	39	870	233	295	870
			firstReactRender	39	30	72	11	43	72
			getState	134	102	260	38	142	260
			initialActions	7	1	37	9	10	37
			loadScripts	1560	1284	2013	227	1747	2013
			setupStore	39	7	177	46	71	177
			numNetworkReqs	273	155	597	134	398	597

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -918 Bytes (-0.01%)
common: 1.28 KiB (0.01%)

jpuri · 2025-11-03T04:17:43Z

ui/pages/confirmations/confirm/confirm.test.tsx

-      expect(container).toMatchSnapshot();
-    });
+    const signatureRender = await renderConfirm(mockStoreSign);
+    expect(signatureRender.container).toMatchSnapshot();


Nice cleanup

metamaskbot · 2025-11-03T12:21:54Z

Builds ready [0ecfcf5]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1275 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1275	1107	1513	96	1322	1471
			load	1099	958	1329	86	1152	1247
			domContentLoaded	1093	953	1323	84	1145	1235
			domInteractive	21	14	91	13	20	55
			firstPaint	637	115	1336	437	1097	1242
			backgroundConnect	231	217	261	8	235	250
			firstReactRender	29	18	55	9	37	47
			getState	23	7	110	15	25	40
			initialActions	6	1	56	7	7	21
			loadScripts	868	720	1090	83	920	1014
			setupStore	10	6	31	3	11	15
			numNetworkReqs	13	6	76	20	6	72
	Browserify	Power User Home	uiStartup	2116	1835	2945	381	2541	2945
			load	1116	966	1504	198	1396	1504
			domContentLoaded	1104	946	1495	198	1391	1495
			domInteractive	28	15	65	17	48	65
			firstPaint	760	157	1499	491	1088	1499
			backgroundConnect	246	225	279	16	263	279
			firstReactRender	27	26	32	2	27	32
			getState	177	156	205	15	195	205
			initialActions	7	2	43	10	6	43
			loadScripts	872	724	1223	189	1160	1223
			setupStore	13	10	31	6	13	31
			numNetworkReqs	187	103	356	104	314	356
	Webpack	Standard Home	uiStartup	794	671	1170	93	799	1007
			load	586	536	982	79	592	776
			domContentLoaded	578	530	963	76	584	762
			domInteractive	15	11	79	9	14	32
			firstPaint	211	54	970	206	169	731
			backgroundConnect	26	13	88	15	29	71
			firstReactRender	27	16	57	8	32	35
			getState	11	6	18	3	14	16
			initialActions	3	0	20	3	4	9
			loadScripts	575	528	929	73	582	755
			setupStore	10	5	30	4	12	16
			numNetworkReqs	14	6	77	20	8	74
	Webpack	Power User Home	uiStartup	1337	1166	1835	206	1470	1835
			load	659	598	872	82	749	872
			domContentLoaded	639	587	830	70	708	830
			domInteractive	22	13	57	13	37	57
			firstPaint	377	75	714	242	622	714
			backgroundConnect	79	18	276	86	194	276
			firstReactRender	26	24	30	2	26	30
			getState	148	109	172	18	157	172
			initialActions	4	0	20	5	7	20
			loadScripts	635	585	817	66	697	817
			setupStore	11	6	27	7	15	27
			numNetworkReqs	147	97	274	59	194	274
Firefox	Browserify	Standard Home	uiStartup	1501	1279	2015	146	1574	1870
			load	1274	1090	1690	100	1350	1429
			domContentLoaded	1274	1090	1690	100	1349	1429
			domInteractive	120	35	420	58	135	233
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	27	160	23	52	95
			firstReactRender	25	21	49	5	26	38
			getState	13	3	199	28	9	32
			initialActions	4	2	22	4	4	14
			loadScripts	1246	1070	1666	97	1315	1400
			setupStore	13	7	38	7	13	32
			numNetworkReqs	13	6	66	17	7	64
	Browserify	Power User Home	uiStartup	2501	2164	2886	261	2825	2886
			load	1410	1222	1660	163	1634	1660
			domContentLoaded	1409	1222	1659	163	1633	1659
			domInteractive	209	89	512	166	466	512
			firstPaint	-	-	-	-	-	-
			backgroundConnect	108	31	336	90	186	336
			firstReactRender	39	30	61	9	46	61
			getState	149	105	331	54	177	331
			initialActions	31	1	217	54	35	217
			loadScripts	1376	1201	1618	159	1577	1618
			setupStore	38	8	161	42	52	161
			numNetworkReqs	159	70	362	84	224	362
	Webpack	Standard Home	uiStartup	1636	1403	2560	189	1655	2039
			load	1404	1207	2020	130	1453	1645
			domContentLoaded	1403	1207	2020	130	1453	1645
			domInteractive	105	29	580	54	112	153
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	27	135	27	55	114
			firstReactRender	29	23	73	9	30	42
			getState	8	4	45	5	8	17
			initialActions	5	2	43	7	4	25
			loadScripts	1371	1185	1935	119	1427	1564
			setupStore	18	6	198	26	13	76
			numNetworkReqs	13	6	69	18	7	66
	Webpack	Power User Home	uiStartup	2533	2140	3129	342	3016	3129
			load	1520	1244	1860	200	1760	1860
			domContentLoaded	1519	1244	1858	200	1759	1858
			domInteractive	155	81	406	94	254	406
			firstPaint	-	-	-	-	-	-
			backgroundConnect	111	30	404	99	174	404
			firstReactRender	38	32	48	6	45	48
			getState	130	88	183	27	152	183
			initialActions	9	1	39	10	13	39
			loadScripts	1481	1227	1811	191	1728	1811
			setupStore	32	10	113	31	35	113
			numNetworkReqs	143	62	304	87	230	304

📊 Page Load Benchmark Results

Current Commit: 0ecfcf5 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 726ms (±38ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	41ms	1.01s	1.36s	1.07s	1.36s
domContentLoaded	726ms	38ms	699ms	1.03s	751ms	1.03s
firstPaint	77ms	12ms	64ms	188ms	84ms	188ms
firstContentfulPaint	77ms	12ms	64ms	188ms	84ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -923 Bytes (-0.01%)
common: 1.45 KiB (0.02%)

metamaskbot · 2025-11-03T13:21:09Z

Builds ready [c4149da]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1320 ± 110 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1320	1117	1592	110	1401	1525
			load	1143	967	1378	101	1211	1313
			domContentLoaded	1136	962	1371	100	1203	1304
			domInteractive	22	15	146	16	19	49
			firstPaint	705	73	1380	455	1157	1275
			backgroundConnect	234	219	252	7	239	249
			firstReactRender	31	19	67	9	38	50
			getState	21	9	47	7	23	35
			initialActions	7	1	72	9	7	17
			loadScripts	909	741	1144	99	976	1084
			setupStore	10	6	23	3	11	17
			numNetworkReqs	13	6	74	19	6	71
	Browserify	Power User Home	uiStartup	2142	1842	3539	460	2582	3539
			load	1128	951	1814	260	1428	1814
			domContentLoaded	1121	941	1808	259	1409	1808
			domInteractive	30	16	81	21	57	81
			firstPaint	670	157	1437	404	1012	1437
			backgroundConnect	247	229	290	15	258	290
			firstReactRender	27	26	31	1	28	31
			getState	196	167	269	25	204	269
			initialActions	10	2	81	19	7	81
			loadScripts	888	720	1532	248	1164	1532
			setupStore	13	10	29	6	13	29
			numNetworkReqs	155	104	317	83	249	317
	Webpack	Standard Home	uiStartup	872	742	1208	90	877	1121
			load	652	598	984	73	658	855
			domContentLoaded	643	590	961	70	649	827
			domInteractive	16	12	39	7	15	35
			firstPaint	212	59	964	208	203	635
			backgroundConnect	29	13	95	19	30	81
			firstReactRender	29	17	65	8	34	37
			getState	12	6	19	3	15	18
			initialActions	4	1	17	3	5	10
			loadScripts	640	588	950	68	647	816
			setupStore	11	6	21	4	13	19
			numNetworkReqs	14	6	78	20	8	74
	Webpack	Power User Home	uiStartup	1337	1176	1911	254	1378	1911
			load	701	602	1000	139	753	1000
			domContentLoaded	679	591	944	121	748	944
			domInteractive	27	12	82	24	32	82
			firstPaint	366	116	947	285	608	947
			backgroundConnect	65	11	228	73	53	228
			firstReactRender	26	24	38	3	26	38
			getState	146	69	197	29	160	197
			initialActions	7	0	56	14	11	56
			loadScripts	674	589	934	118	746	934
			setupStore	11	6	29	8	10	29
			numNetworkReqs	148	100	285	71	199	285
Firefox	Browserify	Standard Home	uiStartup	1432	1242	1726	112	1504	1667
			load	1229	1080	1411	83	1290	1379
			domContentLoaded	1229	1079	1411	83	1290	1379
			domInteractive	113	33	341	44	125	192
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	26	133	21	51	103
			firstReactRender	24	21	52	5	24	34
			getState	7	4	41	5	7	15
			initialActions	3	1	15	3	3	13
			loadScripts	1201	1061	1373	78	1260	1347
			setupStore	12	7	49	7	12	32
			numNetworkReqs	12	6	65	16	7	60
	Browserify	Power User Home	uiStartup	2374	2008	2883	291	2724	2883
			load	1344	1085	1723	184	1539	1723
			domContentLoaded	1344	1085	1723	185	1538	1723
			domInteractive	174	66	400	101	275	400
			firstPaint	-	-	-	-	-	-
			backgroundConnect	148	34	453	141	241	453
			firstReactRender	37	27	70	10	44	70
			getState	117	76	191	29	125	191
			initialActions	6	2	25	6	8	25
			loadScripts	1287	1065	1593	151	1322	1593
			setupStore	35	6	91	24	54	91
			numNetworkReqs	140	70	330	78	211	330
	Webpack	Standard Home	uiStartup	1571	1358	2074	145	1590	1941
			load	1349	1171	1638	99	1382	1598
			domContentLoaded	1349	1171	1638	99	1382	1598
			domInteractive	101	34	235	33	120	163
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	24	190	29	53	112
			firstReactRender	30	22	75	13	28	67
			getState	9	3	49	7	9	25
			initialActions	6	1	155	16	3	20
			loadScripts	1320	1155	1607	92	1340	1536
			setupStore	15	6	191	20	12	39
			numNetworkReqs	13	6	71	18	7	67
	Webpack	Power User Home	uiStartup	2508	2151	3520	422	2636	3520
			load	1473	1229	1917	205	1600	1917
			domContentLoaded	1473	1228	1916	205	1600	1916
			domInteractive	159	58	432	113	267	432
			firstPaint	-	-	-	-	-	-
			backgroundConnect	96	27	274	73	145	274
			firstReactRender	46	29	94	21	50	94
			getState	121	75	158	17	128	158
			initialActions	15	1	125	30	16	125
			loadScripts	1441	1210	1872	198	1571	1872
			setupStore	35	6	116	37	72	116
			numNetworkReqs	135	57	337	98	228	337

📊 Page Load Benchmark Results

Current Commit: c4149da | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±49ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 713ms (±45ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±15ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	49ms	1.00s	1.43s	1.06s	1.43s
domContentLoaded	713ms	45ms	695ms	1.09s	745ms	1.09s
firstPaint	76ms	15ms	56ms	208ms	84ms	208ms
firstContentfulPaint	76ms	15ms	56ms	208ms	84ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -923 Bytes (-0.01%)
common: 1.45 KiB (0.02%)

metamaskbot · 2025-11-03T14:29:30Z

Builds ready [8a30e82]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1272 ± 91 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1272	1111	1612	91	1331	1435
			load	1095	958	1342	82	1159	1241
			domContentLoaded	1089	953	1329	80	1153	1226
			domInteractive	21	14	86	12	18	50
			firstPaint	639	89	1334	442	1099	1230
			backgroundConnect	230	217	255	7	234	241
			firstReactRender	30	19	63	8	37	44
			getState	21	9	95	12	24	36
			initialActions	7	0	77	11	7	21
			loadScripts	865	736	1086	79	934	999
			setupStore	11	7	32	4	11	20
			numNetworkReqs	13	6	76	20	6	75
	Browserify	Power User Home	uiStartup	2065	1765	3328	424	2333	3328
			load	1108	947	1872	255	1277	1872
			domContentLoaded	1099	941	1865	254	1271	1865
			domInteractive	28	14	70	19	56	70
			firstPaint	643	163	1460	482	1112	1460
			backgroundConnect	253	230	394	38	255	394
			firstReactRender	26	23	32	2	26	32
			getState	183	159	248	21	193	248
			initialActions	5	1	26	6	5	26
			loadScripts	860	716	1476	223	1045	1476
			setupStore	10	9	12	1	11	12
			numNetworkReqs	154	102	315	84	272	315
	Webpack	Standard Home	uiStartup	877	726	1288	101	896	1173
			load	653	584	1025	84	654	917
			domContentLoaded	644	577	1009	81	648	899
			domInteractive	16	11	44	7	15	35
			firstPaint	232	58	944	238	200	896
			backgroundConnect	29	13	106	19	30	84
			firstReactRender	29	16	52	8	35	40
			getState	13	7	25	4	16	19
			initialActions	4	1	18	3	5	10
			loadScripts	641	575	998	79	646	887
			setupStore	11	6	26	4	13	18
			numNetworkReqs	14	6	79	20	8	71
	Webpack	Power User Home	uiStartup	1315	1111	1822	222	1294	1822
			load	681	609	915	97	699	915
			domContentLoaded	665	598	867	87	684	867
			domInteractive	23	13	64	17	36	64
			firstPaint	338	95	870	295	666	870
			backgroundConnect	65	11	217	70	94	217
			firstReactRender	26	24	28	1	27	28
			getState	141	57	166	28	156	166
			initialActions	3	0	18	4	3	18
			loadScripts	660	596	856	84	672	856
			setupStore	10	6	27	6	12	27
			numNetworkReqs	144	83	284	70	195	284
Firefox	Browserify	Standard Home	uiStartup	1550	1290	2116	124	1614	1793
			load	1316	1109	1501	90	1376	1490
			domContentLoaded	1316	1109	1501	90	1376	1490
			domInteractive	121	37	372	55	133	246
			firstPaint	-	-	-	-	-	-
			backgroundConnect	56	27	196	33	60	150
			firstReactRender	27	22	40	3	28	33
			getState	10	5	192	19	8	15
			initialActions	6	1	85	9	5	15
			loadScripts	1280	1085	1474	87	1339	1446
			setupStore	15	7	58	8	14	36
			numNetworkReqs	13	6	68	17	7	64
	Browserify	Power User Home	uiStartup	2520	2217	3483	329	2687	3483
			load	1398	1138	1803	199	1644	1803
			domContentLoaded	1398	1137	1803	199	1643	1803
			domInteractive	197	86	465	144	416	465
			firstPaint	-	-	-	-	-	-
			backgroundConnect	126	31	568	141	152	568
			firstReactRender	40	30	56	8	48	56
			getState	145	75	192	31	174	192
			initialActions	12	1	77	19	16	77
			loadScripts	1359	1115	1683	182	1610	1683
			setupStore	32	8	109	27	42	109
			numNetworkReqs	138	72	321	75	209	321
	Webpack	Standard Home	uiStartup	1641	1465	2212	122	1685	1918
			load	1417	1269	1627	84	1464	1612
			domContentLoaded	1417	1269	1627	84	1464	1611
			domInteractive	100	32	240	29	112	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	50	26	123	23	56	115
			firstReactRender	31	23	76	12	29	72
			getState	8	4	48	5	8	15
			initialActions	5	1	46	6	4	17
			loadScripts	1385	1240	1582	77	1432	1541
			setupStore	15	7	235	23	13	35
			numNetworkReqs	13	6	69	17	7	65
	Webpack	Power User Home	uiStartup	2531	2073	3287	412	3024	3287
			load	1529	1208	2049	274	1804	2049
			domContentLoaded	1529	1208	2049	274	1803	2049
			domInteractive	193	79	525	156	370	525
			firstPaint	-	-	-	-	-	-
			backgroundConnect	121	29	409	108	224	409
			firstReactRender	36	29	56	7	37	56
			getState	130	91	206	33	130	206
			initialActions	14	1	107	29	11	107
			loadScripts	1487	1190	1988	256	1729	1988
			setupStore	28	5	183	43	22	183
			numNetworkReqs	138	63	341	92	224	341

📊 Page Load Benchmark Results

Current Commit: 8a30e82 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.01s (±42ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 699ms (±38ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.01s	42ms	984ms	1.32s	1.06s	1.32s
domContentLoaded	699ms	38ms	677ms	976ms	732ms	976ms
firstPaint	78ms	12ms	60ms	180ms	92ms	180ms
firstContentfulPaint	78ms	12ms	60ms	180ms	92ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -923 Bytes (-0.01%)
common: 1.46 KiB (0.02%)

metamaskbot · 2025-11-03T15:09:39Z

Builds ready [7f54bf7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- content-script: 0
- offscreen: 0

UI Startup Metrics (1217 ± 102 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1217	1013	1460	102	1292	1390
			load	1047	876	1224	91	1118	1169
			domContentLoaded	1041	874	1211	90	1111	1160
			domInteractive	19	14	54	8	18	43
			firstPaint	689	81	1243	420	1078	1187
			backgroundConnect	189	176	226	9	194	208
			firstReactRender	31	16	59	9	37	46
			getState	19	7	60	9	22	32
			initialActions	8	1	56	10	7	28
			loadScripts	858	699	1029	88	926	976
			setupStore	10	5	24	3	12	16
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2107	1792	3456	475	2369	3456
			load	1112	953	1805	249	1329	1805
			domContentLoaded	1102	945	1796	249	1321	1796
			domInteractive	30	15	82	22	44	82
			firstPaint	676	171	1492	452	995	1492
			backgroundConnect	250	227	300	20	260	300
			firstReactRender	27	24	34	2	28	34
			getState	182	159	265	26	198	265
			initialActions	5	2	12	2	6	12
			loadScripts	867	719	1519	235	1068	1519
			setupStore	11	9	16	2	12	16
			numNetworkReqs	158	102	317	82	240	317
	Webpack	Standard Home	uiStartup	882	739	1364	105	893	1168
			load	659	599	1102	92	656	945
			domContentLoaded	652	591	1083	89	649	927
			domInteractive	16	11	64	8	15	36
			firstPaint	204	59	1086	218	169	896
			backgroundConnect	27	13	78	15	28	71
			firstReactRender	29	18	63	9	34	43
			getState	13	7	28	4	16	22
			initialActions	3	1	21	3	4	10
			loadScripts	648	589	1072	87	647	916
			setupStore	12	5	26	4	14	20
			numNetworkReqs	14	6	79	20	8	72
	Webpack	Power User Home	uiStartup	1374	1179	1928	268	1656	1928
			load	701	607	1022	134	867	1022
			domContentLoaded	684	596	993	123	827	993
			domInteractive	22	13	50	14	40	50
			firstPaint	426	107	884	268	616	884
			backgroundConnect	80	21	243	78	131	243
			firstReactRender	26	25	28	1	26	28
			getState	147	109	165	17	159	165
			initialActions	4	0	24	7	10	24
			loadScripts	679	594	981	120	817	981
			setupStore	9	6	22	4	10	22
			numNetworkReqs	166	94	294	78	264	294
Firefox	Browserify	Standard Home	uiStartup	1478	1271	1796	116	1554	1689
			load	1265	1110	1510	88	1337	1432
			domContentLoaded	1265	1110	1510	88	1337	1432
			domInteractive	123	36	304	50	133	250
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	25	137	20	52	89
			firstReactRender	25	21	52	5	25	36
			getState	10	4	183	19	8	21
			initialActions	5	1	42	6	4	15
			loadScripts	1237	1092	1432	83	1302	1408
			setupStore	12	7	80	9	12	31
			numNetworkReqs	12	6	67	16	8	63
	Browserify	Power User Home	uiStartup	2714	2245	3511	387	3230	3511
			load	1473	1252	1967	236	1704	1967
			domContentLoaded	1473	1251	1967	236	1703	1967
			domInteractive	226	93	635	176	457	635
			firstPaint	-	-	-	-	-	-
			backgroundConnect	158	33	522	147	245	522
			firstReactRender	47	33	95	15	52	95
			getState	162	116	274	48	188	274
			initialActions	9	1	39	9	10	39
			loadScripts	1422	1224	1923	226	1635	1923
			setupStore	53	6	242	64	80	242
			numNetworkReqs	140	68	322	85	225	322
	Webpack	Standard Home	uiStartup	1602	1403	2225	140	1617	1917
			load	1377	1181	1708	105	1426	1605
			domContentLoaded	1377	1180	1707	105	1426	1604
			domInteractive	102	33	313	43	109	178
			firstPaint	-	-	-	-	-	-
			backgroundConnect	49	26	144	26	54	122
			firstReactRender	32	23	81	15	30	76
			getState	8	4	30	4	8	15
			initialActions	6	1	187	19	3	16
			loadScripts	1348	1164	1625	97	1406	1555
			setupStore	13	6	64	10	12	38
			numNetworkReqs	13	6	70	17	7	65
	Webpack	Power User Home	uiStartup	2544	2299	3175	222	2661	3175
			load	1547	1308	1857	177	1690	1857
			domContentLoaded	1546	1307	1856	177	1690	1856
			domInteractive	165	73	502	129	288	502
			firstPaint	-	-	-	-	-	-
			backgroundConnect	93	32	326	73	111	326
			firstReactRender	47	33	94	14	53	94
			getState	156	87	320	58	195	320
			initialActions	9	1	24	8	18	24
			loadScripts	1510	1287	1815	168	1653	1815
			setupStore	41	11	160	40	50	160
			numNetworkReqs	132	54	235	68	207	235

📊 Page Load Benchmark Results

Current Commit: 7f54bf7 | Date: 11/3/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 728ms (±36ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.02s	1.32s	1.08s	1.32s
domContentLoaded	728ms	36ms	706ms	982ms	765ms	982ms
firstPaint	79ms	12ms	60ms	176ms	92ms	176ms
firstContentfulPaint	79ms	12ms	60ms	176ms	92ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 68 Bytes (0%)
ui: -939 Bytes (-0.01%)
common: 1.46 KiB (0.02%)

pedronfigueiredo self-assigned this Oct 31, 2025

pedronfigueiredo requested a review from a team as a code owner October 31, 2025 17:11

pedronfigueiredo added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Oct 31, 2025

pedronfigueiredo force-pushed the pnf/address-confirm-test-warnings branch from f40a9a7 to e372f77 Compare October 31, 2025 17:13

github-actions bot added the size-M label Oct 31, 2025

jpuri reviewed Nov 3, 2025

View reviewed changes

jpuri previously approved these changes Nov 3, 2025

View reviewed changes

pedronfigueiredo dismissed jpuri’s stale review via d3195ef November 3, 2025 11:54

pedronfigueiredo force-pushed the pnf/address-confirm-test-warnings branch 2 times, most recently from d3195ef to 0ecfcf5 Compare November 3, 2025 11:54

github-actions bot added size-L and removed size-M labels Nov 3, 2025

pedronfigueiredo force-pushed the pnf/address-confirm-test-warnings branch from 8a30e82 to abbd8bf Compare November 3, 2025 14:33

pedronfigueiredo requested a review from a team as a code owner November 3, 2025 14:33

chore: Refactor to remove warnings in confirmations'

7f54bf7

pedronfigueiredo force-pushed the pnf/address-confirm-test-warnings branch from abbd8bf to 7f54bf7 Compare November 3, 2025 14:44

chore: Refactor to remove warnings in confirmations' confirm.test.tsx #37431

Are you sure you want to change the base?

chore: Refactor to remove warnings in confirmations' confirm.test.tsx #37431

Conversation

pedronfigueiredo commented Oct 31, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

metamaskbot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 31, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 31, 2025

Uh oh!

jpuri Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 3, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: Refactor to remove warnings in confirmations' `confirm.test.tsx` #37431

chore: Refactor to remove warnings in confirmations' `confirm.test.tsx` #37431

pedronfigueiredo commented Oct 31, 2025 •

edited by cursor bot

Loading

metamaskbot commented Oct 31, 2025 •

edited

Loading