refactor: html dir #38064
Open
refactor: html dir #38064
+77
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsyoboieltr
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [90ec351]
UI Startup Metrics (1207 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [35866ec]
UI Startup Metrics (1208 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
previously approved these changes
Nov 21, 2025
HowardBraham
approved these changes
Nov 21, 2025
davidmurdoch
approved these changes
Nov 21, 2025
github-project-automation
bot
moved this from Review in progress
to Review finalised - Ready to be merged
in PR review queue
Collaborator
Builds ready [4cbb514]
UI Startup Metrics (1229 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Nov 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were matching all .html files in the app dir to be bundled, so the partial html files were unnecessarily included. This PR aims to solve this problem and separate html pages from partials. The build output should not contain any partial html files.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6314
Manual testing steps
yarn webpackScreenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Move HTML pages to
app/html/pages, introduce partials inapp/html/partials, and update build/webpack scripts and tests to target the new structure and paths.app/html/pages(e.g.,background.html,home.html); removeapp/*.html.app/html/partialsand switch includes tohtml/partials/*.development/build/scripts.jsto read fromapp/html/pagesand adjust asset/script path replacements (../../*→ bundled paths).collectEntriesnow scansapp/html/pagesfor HTML; background/offscreen handling unchanged.join(appRoot, 'html', 'pages', *.html).loading.html,notification.html,popup.html,sidepanel.html,offscreen.html,trezor-usb-permissions.htmlto use../../and new partials.Written by Cursor Bugbot for commit 4cbb514. This will update automatically on new commits. Configure here.