Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 20, 2025

Description

The recent addition of the tabs permission will result in new permission warnings upon update, which is extremely disruptive and is something we'd never do except as a last resort.

The permission wasn't actually needed, and has been removed. This removal uncovered a bug in our Webpack build (the tabs permission was erroneously only added for MV2 test builds, but we need it for MV3 test builds as well), which has been fixed.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Remove unnecessary extension permission

Related issues

N/A

Manual testing steps

Test that the sidepanel still works in general. Particularly with dapp confirmations, and the "Connected status" indicator, and current selected dapp.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Removes tabs from the MV3 manifest and updates the build transform to add tabs only for test builds (all manifest versions).

  • Manifest (MV3):
    • Remove tabs from permissions in app/manifest/v3/_base.json.
  • Build/Manifest transform:
    • Update transformManifest in development/webpack/utils/plugins/ManifestPlugin/helpers.ts to add tabs when args.test is true, regardless of manifest_version.
    • Retains error if tabs already exists and continues adding dev/test manifest key.

Written by Cursor Bugbot for commit 862591e. This will update automatically on new commits. Configure here.

The recent addition of the `tabs` permission will result in new
permission warnings upon update, which is extremely disruptive and is
something we'd never do except as a last resort.

This is a test of whether the permission can simply be removed, or if
further changes are needed.
@metamaskbot metamaskbot added the team-core-platform Core Platform team label Nov 20, 2025
@gauthierpetetin gauthierpetetin changed the title fix: Remove tabs permission to avoid new warnings fix: Remove tabs permission to avoid new warnings cp-13.10.1 Nov 20, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [862591e]
UI Startup Metrics (1250 ± 102 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12501080162010213111446
load106189713749511221225
domContentLoaded105486713669511151214
domInteractive2514103202087
firstPaint4699612513939321217
backgroundConnect22019932017225251
firstReactRender291875103348
getState3418104143856
initialActions106112
loadScripts842666113791898999
setupStore1172631218
numNetworkReqs1257720572
BrowserifyPower User HomeuiStartup18811565264123420492340
load998870165414910031373
domContentLoaded98386316431479821362
domInteractive34162223727150
firstPaint5989016593899311282
backgroundConnect22320326211228243
firstReactRender80471171386103
getState17413130242190273
initialActions105112
loadScripts77766614301457751145
setupStore201078122540
numNetworkReqs1226929549154210
WebpackStandard HomeuiStartup815720120682846982
load617559105277629757
domContentLoaded612556104576625751
domInteractive241392192080
firstPaint240711050187208609
backgroundConnect1163971328
firstReactRender28206973236
getState291457103644
initialActions103112
loadScripts609554103574622742
setupStore1163441318
numNetworkReqs1257720573
WebpackPower User HomeuiStartup13951023259123915311913
load6375531515134638953
domContentLoaded6275471502133622943
domInteractive33162523627121
firstPaint290108969205318665
backgroundConnect1473761734
firstReactRender82491621589102
getState16213530633162245
initialActions104012
loadScripts6245461494131620934
setupStore21856123248
numNetworkReqs1446731054177284
FirefoxBrowserifyStandard HomeuiStartup11881040160812512471460
load100489612518510511168
domContentLoaded100289612518510511168
domInteractive58282404282138
firstPaint------
backgroundConnect3420161203765
firstReactRender20173432132
getState1158211941
initialActions102012
loadScripts98388012378210271143
setupStore11517017922
numNetworkReqs1156915659
BrowserifyPower User HomeuiStartup26891976373936628493550
load1164940160216812241507
domContentLoaded1163933160116812241506
domInteractive15130568127169496
firstPaint------
backgroundConnect22624915236281777
firstReactRender85501291795119
getState29486883268374872
initialActions209227
loadScripts1117924153115911611482
setupStore1207857180117743
numNetworkReqs97612154194205
WebpackStandard HomeuiStartup14211250186811514741677
load1218106214558912861368
domContentLoaded1218106214498912861368
domInteractive55272293778132
firstPaint------
backgroundConnect4220137224395
firstReactRender26216762733
getState963341016
initialActions103112
loadScripts1193104713858312641339
setupStore13616720956
numNetworkReqs1256917663
WebpackPower User HomeuiStartup28542043378937031083501
load13901115180117115221711
domContentLoaded13901115179617115211711
domInteractive12930526111147424
firstPaint------
backgroundConnect18230766173238587
firstReactRender86381592197126
getState283831661327207899
initialActions3135538
loadScripts13481089173216814431684
setupStore86577614087290
numNetworkReqs96532094198200
📊 Page Load Benchmark Results

Current Commit: 862591e | Date: 11/20/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±35ms) 🟢 | historical mean value: 732ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 43ms 1.01s 1.31s 1.08s 1.31s
domContentLoaded 723ms 35ms 699ms 982ms 748ms 982ms
firstPaint 77ms 11ms 64ms 164ms 84ms 164ms
firstContentfulPaint 77ms 11ms 64ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@Gudahtt Gudahtt marked this pull request as ready for review November 21, 2025 14:35
@Gudahtt Gudahtt added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2025
@gauthierpetetin gauthierpetetin added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit bba4201 Nov 21, 2025
340 of 342 checks passed
@gauthierpetetin gauthierpetetin deleted the remove-tabs-permission branch November 21, 2025 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.12.0 Issue or pull request that will be included in release 13.12.0 size-XS team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants