-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Remove tabs permission to avoid new warnings cp-13.10.1
#38075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent addition of the `tabs` permission will result in new permission warnings upon update, which is extremely disruptive and is something we'd never do except as a last resort. This is a test of whether the permission can simply be removed, or if further changes are needed.
tabs permission to avoid new warningstabs permission to avoid new warnings cp-13.10.1
Collaborator
Builds ready [862591e]
UI Startup Metrics (1250 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
approved these changes
Nov 21, 2025
NidhiKJha
approved these changes
Nov 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.12.0
Issue or pull request that will be included in release 13.12.0
size-XS
team-core-platform
Core Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent addition of the
tabspermission will result in new permission warnings upon update, which is extremely disruptive and is something we'd never do except as a last resort.The permission wasn't actually needed, and has been removed. This removal uncovered a bug in our Webpack build (the
tabspermission was erroneously only added for MV2 test builds, but we need it for MV3 test builds as well), which has been fixed.Changelog
CHANGELOG entry: Remove unnecessary extension permission
Related issues
N/A
Manual testing steps
Test that the sidepanel still works in general. Particularly with dapp confirmations, and the "Connected status" indicator, and current selected dapp.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes
tabsfrom the MV3 manifest and updates the build transform to addtabsonly for test builds (all manifest versions).tabsfrompermissionsinapp/manifest/v3/_base.json.transformManifestindevelopment/webpack/utils/plugins/ManifestPlugin/helpers.tsto addtabswhenargs.testis true, regardless ofmanifest_version.tabsalready exists and continues adding dev/test manifest key.Written by Cursor Bugbot for commit 862591e. This will update automatically on new commits. Configure here.