Skip to content

Conversation

@MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Nov 21, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Nov 21, 2025
@MajorLift MajorLift force-pushed the jongsun/build/webpack/react-compiler-debug-mode branch 2 times, most recently from ac67db5 to 3f87f45 Compare November 21, 2025 13:01
@MajorLift
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [3f87f45]
UI Startup Metrics (1226 ± 94 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1226107514359412941422
load105292412558511071208
domContentLoaded104692112498411011203
domInteractive241499162161
firstPaint4628712133959801197
backgroundConnect2121982518216228
firstReactRender302069103849
getState331871113953
initialActions105113
loadScripts839710105284892992
setupStore1152641219
numNetworkReqs1257720572
BrowserifyPower User HomeuiStartup19091589322227320882436
load1027883207218110481493
domContentLoaded1012876202617710241482
domInteractive35171823729152
firstPaint5448220764309521413
backgroundConnect23020527114237260
firstReactRender7642102128493
getState18213135145195294
initialActions105112
loadScripts80067818011758091254
setupStore20765102737
numNetworkReqs1497129149190233
WebpackStandard HomeuiStartup809717101870834961
load61656181059624781
domContentLoaded61255680358620775
domInteractive231377162171
firstPaint24277807176220635
backgroundConnect1163371228
firstReactRender3021100113339
getState301378113746
initialActions106112
loadScripts60955479456618766
setupStore1253351422
numNetworkReqs1257720573
WebpackPower User HomeuiStartup14181060224623715781868
load6705841091116686978
domContentLoaded6605751073114671965
domInteractive35171833527130
firstPaint308100986227370946
backgroundConnect1574171931
firstReactRender80511111288100
getState1507126538167251
initialActions102012
loadScripts6575731071112669956
setupStore22981143155
numNetworkReqs966920234104194
FirefoxBrowserifyStandard HomeuiStartup12861129160211613521523
load108896513058011481240
domContentLoaded108796413058111471240
domInteractive65322313887138
firstPaint------
backgroundConnect3924129194385
firstReactRender23185252338
getState11691111024
initialActions103012
loadScripts106494812847711151214
setupStore106658922
numNetworkReqs1256917664
BrowserifyPower User HomeuiStartup27222032377036928943585
load1190967173016612101550
domContentLoaded1190967173016712101549
domInteractive14432605126161464
firstPaint------
backgroundConnect237301082271240886
firstReactRender83371742092114
getState24876890241204833
initialActions3039537
loadScripts1146944170615911561483
setupStore1407815198138768
numNetworkReqs97562274296219
WebpackStandard HomeuiStartup14081255179412714501706
load1207107414529412621418
domContentLoaded1207107414529412611418
domInteractive52261523271131
firstPaint------
backgroundConnect4017111204190
firstReactRender26196462638
getState116131131017
initialActions103112
loadScripts1183105114188712361372
setupStore1259214944
numNetworkReqs1256716662
WebpackPower User HomeuiStartup27471999374530428933413
load13771117191118414811810
domContentLoaded13771117191018414801810
domInteractive13831664137151525
firstPaint------
backgroundConnect14929919156172557
firstReactRender82371612294120
getState30475855280539809
initialActions4049737
loadScripts13421094186317514171767
setupStore120880219287726
numNetworkReqs97592244498213
📊 Page Load Benchmark Results

Current Commit: 3f87f45 | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±66ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 739ms (±63ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 79ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 66ms 1.02s 1.37s 1.27s 1.37s
domContentLoaded 739ms 63ms 707ms 1.02s 943ms 1.02s
firstPaint 79ms 11ms 64ms 176ms 88ms 176ms
firstContentfulPaint 79ms 11ms 64ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@MajorLift MajorLift force-pushed the jongsun/build/webpack/react-compiler-debug-mode branch from 3f87f45 to 5d08e68 Compare November 21, 2025 18:45
@MajorLift MajorLift changed the title build(webpack): React Compiler debug mode build(webpack): Add verbose, debug modes for React Compiler Webpack loader Nov 21, 2025
@MajorLift MajorLift force-pushed the jongsun/build/webpack/react-compiler-debug-mode branch 2 times, most recently from 8dc6a66 to aaabb13 Compare November 21, 2025 19:41
@metamaskbot
Copy link
Collaborator

Builds ready [aaabb13]
UI Startup Metrics (1188 ± 99 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1188103415299912341390
load102489912288410761188
domContentLoaded101889612228310701181
domInteractive231481162072
firstPaint52576124441510221195
backgroundConnect2081972659210227
firstReactRender28185483243
getState31185993451
initialActions108113
loadScripts816695101683866977
setupStore1162641119
numNetworkReqs1257821574
BrowserifyPower User HomeuiStartup18851529255825120532443
load1000871163716210321464
domContentLoaded985863158915910061453
domInteractive34171743629152
firstPaint55710516374039131415
backgroundConnect22119526612227244
firstReactRender77481391685109
getState18213235949198315
initialActions104112
loadScripts78065913781568001236
setupStore20968102836
numNetworkReqs1537128854195263
WebpackStandard HomeuiStartup8537571287918691060
load642574102371649820
domContentLoaded637571101470644807
domInteractive2616103172372
firstPaint224104814144215621
backgroundConnect1264281131
firstReactRender322210393541
getState321474124049
initialActions105112
loadScripts634569100468641797
setupStore1373251524
numNetworkReqs1257519569
WebpackPower User HomeuiStartup14551190240023716261962
load68058113001286891032
domContentLoaded66957612931276691014
domInteractive37172314128162
firstPaint25688948168268654
backgroundConnect1573671930
firstReactRender7951111118795
getState16112628636172242
initialActions103012
loadScripts66657412781246671003
setupStore24878153459
numNetworkReqs1597031557204256
FirefoxBrowserifyStandard HomeuiStartup11941051159210312371428
load101891911876710651159
domContentLoaded101791911876710651155
domInteractive52301622958126
firstPaint------
backgroundConnect3617143213996
firstReactRender22174962141
getState105798919
initialActions103112
loadScripts99690511446310451116
setupStore106799824
numNetworkReqs1156916760
BrowserifyPower User HomeuiStartup25521874370535027073390
load1159971154815312011511
domContentLoaded1158971154815311951511
domInteractive13434480113151451
firstPaint------
backgroundConnect184241088218194695
firstReactRender81441511990117
getState22655912236180856
initialActions218136
loadScripts1120951150614311301459
setupStore1475808208123692
numNetworkReqs97612204097207
WebpackStandard HomeuiStartup14941320192412615381795
load1281112015359013421452
domContentLoaded1280111915359013421452
domInteractive76302193798134
firstPaint------
backgroundConnect43212543043113
firstReactRender28207283039
getState126153151119
initialActions102122
loadScripts1254110414658213161404
setupStore1265381134
numNetworkReqs1256917664
WebpackPower User HomeuiStartup29642211412037231293809
load15071207207321416581991
domContentLoaded15071207207321416571991
domInteractive16234777155187577
firstPaint------
backgroundConnect223301108246272802
firstReactRender82411231692111
getState28282868268287802
initialActions4056837
loadScripts14691189203020516191923
setupStore9410748132106449
numNetworkReqs97592314297204
📊 Page Load Benchmark Results

Current Commit: aaabb13 | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±36ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 40ms 1.01s 1.33s 1.07s 1.33s
domContentLoaded 717ms 36ms 698ms 991ms 746ms 991ms
firstPaint 76ms 12ms 56ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 56ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

@MajorLift MajorLift force-pushed the jongsun/build/webpack/react-compiler-debug-mode branch from aaabb13 to 68e28d9 Compare November 21, 2025 20:51
@MajorLift MajorLift merged commit 5723799 into jongsun/build/enable-react-compiler-webpack Nov 21, 2025
42 of 45 checks passed
@MajorLift MajorLift deleted the jongsun/build/webpack/react-compiler-debug-mode branch November 21, 2025 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [68e28d9]
UI Startup Metrics (1209 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12091002147010512701400
load104687212459911161214
domContentLoaded103985912359711071196
domInteractive211372131960
firstPaint67191124242210721172
backgroundConnect19818223310202221
firstReactRender28184993347
getState291589123246
initialActions109112
loadScripts847648102395919997
setupStore1162431218
numNetworkReqs1257821574
BrowserifyPower User HomeuiStartup18481526281726720072450
load1000878174716810011457
domContentLoaded98686617341669831444
domInteractive36171783729146
firstPaint5348417464239101467
backgroundConnect21920125310225241
firstReactRender77451441680116
getState17312431837197246
initialActions104112
loadScripts78366815301657771235
setupStore19104492437
numNetworkReqs1086229046122195
WebpackStandard HomeuiStartup8267471052768551007
load62657582661632790
domContentLoaded62257381860627781
domInteractive251496172177
firstPaint25275817191218698
backgroundConnect1263881131
firstReactRender30217373438
getState301461114047
initialActions104112
loadScripts61957180958625771
setupStore1253951422
numNetworkReqs1257519569
WebpackPower User HomeuiStartup14441111272928015732080
load66456814961516821014
domContentLoaded65356014851506661005
domInteractive34161703330124
firstPaint340941131227571770
backgroundConnect1574871929
firstReactRender7947104118697
getState16613735137164264
initialActions102012
loadScripts6505591478147663994
setupStore21884143147
numNetworkReqs1516630957189290
FirefoxBrowserifyStandard HomeuiStartup12541049175112413071539
load106690512778211291221
domContentLoaded106590112778211291221
domInteractive57321763085111
firstPaint------
backgroundConnect3720146193871
firstReactRender23195362337
getState11619519920
initialActions103012
loadScripts104489012507711051197
setupStore1053351026
numNetworkReqs1256716661
BrowserifyPower User HomeuiStartup26942087392833228723478
load1207959169118512601600
domContentLoaded1206958169118512601600
domInteractive14134659133152498
firstPaint------
backgroundConnect222191059248249808
firstReactRender84391561991120
getState23273880238189846
initialActions208127
loadScripts1158944166817411941545
setupStore1136781167122701
numNetworkReqs87522134186198
WebpackStandard HomeuiStartup15001288222514715551768
load1280112615299513381463
domContentLoaded1280112615299513371463
domInteractive68291813694135
firstPaint------
backgroundConnect4420268354588
firstReactRender3122166212966
getState156177221346
initialActions102022
loadScripts1256110914969213151439
setupStore13670111241
numNetworkReqs1257017666
WebpackPower User HomeuiStartup28942090379633630813564
load14561151207120916481856
domContentLoaded14561150207020916481856
domInteractive13931656135154502
firstPaint------
backgroundConnect17429957185193598
firstReactRender84411841994116
getState26573906264223858
initialActions4160737
loadScripts14181135204121016081826
setupStore105478616995574
numNetworkReqs87522294384197
📊 Page Load Benchmark Results

Current Commit: 68e28d9 | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.08s (±73ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 754ms (±70ms) 🟢 | historical mean value: 731ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 80ms (±14ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.08s 73ms 1.03s 1.43s 1.29s 1.43s
domContentLoaded 754ms 70ms 715ms 1.09s 954ms 1.09s
firstPaint 80ms 14ms 64ms 204ms 88ms 204ms
firstContentfulPaint 80ms 14ms 64ms 204ms 88ms 204ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants