fix: cp-13.11.0 sending quote request for only valid swaps #38121
+83
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +5 -12)
|
jpuri
changed the title
jpuri
commented
Nov 21, 2025
| if (swapComparisonDisplayed) { | ||
| dappSwapComparisonDisplayed = true; | ||
| captureDappSwapComparisonDisplayProperties({ | ||
| swap_mm_cta_displayed: 'true', |
Contributor
Author
There was a problem hiding this comment.
Hey @bschorchit : for swap_mm_cta_displayed we need to take missing value as false.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx
Show resolved
Hide resolved
Collaborator
Builds ready [99d90fe]
UI Startup Metrics (1215 ± 91 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
|
||
| import { decodeCommandV3Path } from '../decoding'; | ||
|
|
||
| const DEFAULT_QUOTEFEE = 250; |
Contributor
There was a problem hiding this comment.
Should we fetch this from a remote flag?
Collaborator
Builds ready [ecfc276]
UI Startup Metrics (1266 ± 121 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…ask-extension into dapp_swap_req_fix
Collaborator
Builds ready [c0543d6]
UI Startup Metrics (1242 ± 120 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
previously approved these changes
Nov 24, 2025
cryptotavares
previously approved these changes
Nov 24, 2025
Collaborator
Builds ready [ca6ffaf]
UI Startup Metrics (1351 ± 136 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Nov 25, 2025
cryptotavares
approved these changes
Nov 25, 2025
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request for quotes should only be send for valid confirmation
Changelog
CHANGELOG entry:
Related issues
Fixes: MetaMask/metamask-mobile#23100
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Gate dapp-swap quote fetching behind a remote flag, move fee/walletAddress injection to middleware, simplify getDataFromSwap, and update UI metrics/tests accordingly.
dappSwapMetricsFlagand short-circuits when disabled; prevents quote fetching when off.quotesInputviagetDataFromSwap(chainId, data)and augments it withwalletAddressandfee(from flag or default) beforefetchQuotes.metamask-controllerwithremoteFeatureFlags.dappSwapMetrics.dapp-swap-comparison-utils):getDataFromSwapsignature (removewalletAddress/feeconcerns) and return rawquotesInput.GenericQuoteRequest/default fee from utils.useDappSwapComparisonInfo: update to use newgetDataFromSwap(chainId, data)and handle possibly undefinedcommands.feeandwalletAddressadded in middleware and newgetDataFromSwapshape.Written by Cursor Bugbot for commit ca6ffaf. This will update automatically on new commits. Configure here.