-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: cp-13.11.0 dapp swap comparison latency metrics #38128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (3 files, +26 -30)
|
Builds ready [db2e162]
UI Startup Metrics (1163 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [da1a1f6]
UI Startup Metrics (1247 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Outdated
Show resolved
Hide resolved
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Show resolved
Hide resolved
…amask-extension into latency_metrics_fix
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Outdated
Show resolved
Hide resolved
Builds ready [54370c5]
UI Startup Metrics (1231 ± 101 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Outdated
Show resolved
Hide resolved
Builds ready [bc3200e]
UI Startup Metrics (1213 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Outdated
Show resolved
Hide resolved
Builds ready [228e28d]
UI Startup Metrics (1230 ± 117 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
Outdated
Show resolved
Hide resolved
Builds ready [de9c6fe]
UI Startup Metrics (1283 ± 112 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [5ecb088]
UI Startup Metrics (1342 ± 125 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Fix latency metrics capturing for dapp swap comparison feature.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6329
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors latency metrics to use refs and UI-init timing, conditionally updates/returns values, and updates usage/tests accordingly.
ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.tsuseRef-based timers anchored to UI init time.updateSwapComparisonLatency()return the latency string; expose stringified latencies.useDappSwapComparisonInfo.tsupdateRequestDetectionLatency()only whenquotesInputis present.swapComparisonLatencyfromupdateSwapComparisonLatency()for metrics.useDappSwapComparisonInfo.test.tsupdateSwapComparisonLatencyreturn value) and expectations.Written by Cursor Bugbot for commit de9c6fe. This will update automatically on new commits. Configure here.