Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 21, 2025

Description

Fix latency metrics capturing for dapp swap comparison feature.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6329

Manual testing steps

  1. Submit swap request
  2. Check latency metrics captured

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors latency metrics to use refs and UI-init timing, conditionally updates/returns values, and updates usage/tests accordingly.

  • Hooks:
    • ui/pages/confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts
      • Replace state/context timing with useRef-based timers anchored to UI init time.
      • Make updateSwapComparisonLatency() return the latency string; expose stringified latencies.
  • Usage:
    • useDappSwapComparisonInfo.ts
      • Call updateRequestDetectionLatency() only when quotesInput is present.
      • Use returned swapComparisonLatency from updateSwapComparisonLatency() for metrics.
      • Improve error reporting by sending actual error string; adjust dependencies accordingly.
  • Tests:
    • useDappSwapComparisonInfo.test.ts
      • Update mocks to reflect new latency API (mock updateSwapComparisonLatency return value) and expectations.

Written by Cursor Bugbot for commit de9c6fe. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 21, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 21, 2025

✨ Files requiring CODEOWNER review ✨

@MetaMask/confirmations (3 files, +26 -30)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 hooks/
          • 📁 transactions/
            • 📁 dapp-swap-comparison/
              • 📄 useDappSwapComparisonInfo.test.ts +1 -2
              • 📄 useDappSwapComparisonInfo.ts +5 -5
              • 📄 useDappSwapComparisonLatencyMetrics.ts +20 -23

@metamaskbot
Copy link
Collaborator

Builds ready [db2e162]
UI Startup Metrics (1163 ± 99 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1163100016909912231306
load99384415109810531137
domContentLoaded98683914999710431131
domInteractive211391151864
firstPaint700158150739810351142
backgroundConnect19317825110197211
firstReactRender2818130133345
getState301566103446
initialActions104112
loadScripts801658131697863944
setupStore1162641117
numNetworkReqs1257720575
BrowserifyPower User HomeuiStartup18951596253923520502372
load1009873154616110101470
domContentLoaded99386915321589851441
domInteractive37161724030162
firstPaint60410615474009441415
backgroundConnect22220126011228241
firstReactRender79481241588103
getState17313136240190254
initialActions103112
loadScripts78866713231577841234
setupStore19955102540
numNetworkReqs1376728248173242
WebpackStandard HomeuiStartup8347321054728541007
load62456582862633792
domContentLoaded61956282061628786
domInteractive2514114202186
firstPaint22580827146212604
backgroundConnect1263681330
firstReactRender30214763440
getState301496123746
initialActions104111
loadScripts61656081059626777
setupStore1272841419
numNetworkReqs1257719570
WebpackPower User HomeuiStartup14811244260525616541982
load69359513661317101003
domContentLoaded6825901355130694993
domInteractive37181723631143
firstPaint3031191376223320727
backgroundConnect1574681831
firstReactRender83561171188102
getState15412627335163234
initialActions102011
loadScripts6795881345128692982
setupStore221062123446
numNetworkReqs1156528044125222
FirefoxBrowserifyStandard HomeuiStartup12731086155710613391477
load106692912697511291208
domContentLoaded106592812697611291204
domInteractive64312384284156
firstPaint------
backgroundConnect3921166204278
firstReactRender22184942233
getState11676101020
initialActions102112
loadScripts104291312467110981153
setupStore1165591030
numNetworkReqs1157115752
BrowserifyPower User HomeuiStartup26181835366637628003496
load1146932166918512061531
domContentLoaded1145932166918512061531
domInteractive13230587125154471
firstPaint------
backgroundConnect189221093237206751
firstReactRender83471221692116
getState22183874220176818
initialActions3136427
loadScripts1115902160518111681511
setupStore1146783180104736
numNetworkReqs91602144086187
WebpackStandard HomeuiStartup14651272210415015041772
load12431075154310112931430
domContentLoaded12431074154210112931429
domInteractive70282194195133
firstPaint------
backgroundConnect45213193843114
firstReactRender282075103039
getState1165271125
initialActions103122
loadScripts1219106214609512691402
setupStore13572121046
numNetworkReqs1256517764
WebpackPower User HomeuiStartup29812115430938232213684
load14641137206422816571858
domContentLoaded14631136206422816571858
domInteractive14629815145157497
firstPaint------
backgroundConnect194271055223207730
firstReactRender89422072296123
getState27168898266214853
initialActions4048637
loadScripts14271119204222116171829
setupStore1127743180113713
numNetworkReqs91602114385203
📊 Page Load Benchmark Results

Current Commit: db2e162 | Date: 11/21/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±40ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 720ms (±37ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 40ms 1.00s 1.32s 1.06s 1.32s
domContentLoaded 720ms 37ms 695ms 984ms 747ms 984ms
firstPaint 76ms 12ms 60ms 176ms 84ms 176ms
firstContentfulPaint 76ms 12ms 60ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: -78 Bytes (0%)
  • common: 20 Bytes (0%)

@jpuri jpuri added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [da1a1f6]
UI Startup Metrics (1247 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12471069153510813101479
load106489912989811241251
domContentLoaded105789312919711201244
domInteractive2415114172170
firstPaint55694127643310441249
backgroundConnect21619427214221245
firstReactRender28205383047
getState321471123858
initialActions104112
loadScripts8496901072969121032
setupStore1162831217
numNetworkReqs1257821574
BrowserifyPower User HomeuiStartup18641546297625520152416
load98986018641759731454
domContentLoaded97485318521749531444
domInteractive35162034125150
firstPaint4999513193349051016
backgroundConnect21720025011225242
firstReactRender79491581485100
getState17512838245188262
initialActions104113
loadScripts77366016241717551229
setupStore20757112647
numNetworkReqs1346628952164248
WebpackStandard HomeuiStartup801713102369827954
load60355483260615757
domContentLoaded59854982560611752
domInteractive231495162170
firstPaint223101767150208577
backgroundConnect1153171328
firstReactRender28204253136
getState291361103645
initialActions104111
loadScripts59654781658609743
setupStore1273041321
numNetworkReqs1257519570
WebpackPower User HomeuiStartup14041158245223415161930
load6315491277125641946
domContentLoaded6225421263124627933
domInteractive32152333726125
firstPaint309841294246362954
backgroundConnect1475781727
firstReactRender7945119128898
getState16413229536169251
initialActions102012
loadScripts6195401254122625923
setupStore18854111946
numNetworkReqs1486831155182287
FirefoxBrowserifyStandard HomeuiStartup12431084178811613021452
load104592712737811041189
domContentLoaded104492712737811041189
domInteractive58301933680142
firstPaint------
backgroundConnect4122209254184
firstReactRender21184952232
getState11614716917
initialActions102012
loadScripts101990912197010691156
setupStore13616622932
numNetworkReqs1156514749
BrowserifyPower User HomeuiStartup26902062384537428793669
load1198954177319912571666
domContentLoaded1197949177319912571660
domInteractive13832723132159451
firstPaint------
backgroundConnect198261069245222850
firstReactRender88401772095125
getState25686902259198844
initialActions3133327
loadScripts1163930171119512051627
setupStore99679614796457
numNetworkReqs90602114186195
WebpackStandard HomeuiStartup14431244205313114871746
load1224107715279212711407
domContentLoaded1224107715279212701407
domInteractive68292144083161
firstPaint------
backgroundConnect4022120194381
firstReactRender27217062938
getState1054161021
initialActions103122
loadScripts1200106314728612501372
setupStore146208221444
numNetworkReqs1256918665
WebpackPower User HomeuiStartup29592199414835131823624
load14581138210821116131834
domContentLoaded14571138210821116131834
domInteractive13331704137136500
firstPaint------
backgroundConnect19420956221204787
firstReactRender88421612299130
getState30487952287415898
initialActions50641038
loadScripts14171119206420715701792
setupStore98679816294662
numNetworkReqs91602224481205
📊 Page Load Benchmark Results

Current Commit: da1a1f6 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 720ms (±37ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 74ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.31s 1.09s 1.31s
domContentLoaded 720ms 37ms 697ms 989ms 751ms 989ms
firstPaint 74ms 11ms 60ms 160ms 84ms 160ms
firstContentfulPaint 74ms 11ms 60ms 160ms 84ms 160ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: -78 Bytes (0%)
  • common: 20 Bytes (0%)

@jpuri jpuri marked this pull request as ready for review November 24, 2025 06:41
@jpuri jpuri requested a review from a team as a code owner November 24, 2025 06:41
@jpuri jpuri changed the title fix: dapp swap comparison latency metrics fix: cp-13.11.0 dapp swap comparison latency metrics Nov 24, 2025
@jpuri jpuri enabled auto-merge November 24, 2025 06:48
@metamaskbot
Copy link
Collaborator

Builds ready [54370c5]
UI Startup Metrics (1231 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12311018154910112811437
load104587313248910901236
domContentLoaded103986813138910851226
domInteractive29151592821108
firstPaint52184133640410221144
backgroundConnect22219925812228245
firstReactRender31206193750
getState311976103554
initialActions103112
loadScripts8246631089888621019
setupStore1162941221
numNetworkReqs1257420572
BrowserifyPower User HomeuiStartup18861503300327520192516
load1014882196318510061509
domContentLoaded99987619541849861501
domInteractive41173605628180
firstPaint61413719734359521504
backgroundConnect22320026613230249
firstReactRender81491281488113
getState17412730536190231
initialActions103112
loadScripts79467417411837791274
setupStore19770102436
numNetworkReqs1316729552170248
WebpackStandard HomeuiStartup8367071113928541061
load64857791381658857
domContentLoaded64357390980654851
domInteractive29161302722108
firstPaint23283874163201708
backgroundConnect953551018
firstReactRender28214563439
getState281371123447
initialActions104112
loadScripts64057190678652841
setupStore1162741420
numNetworkReqs1257720572
WebpackPower User HomeuiStartup14921258251223616482013
load69659414211496931113
domContentLoaded68558614071486781099
domInteractive43182815333186
firstPaint288841130226258743
backgroundConnect1675382033
firstReactRender84501371389101
getState15712428129165205
initialActions107112
loadScripts68258413961466751090
setupStore21965142658
numNetworkReqs1446730353177263
FirefoxBrowserifyStandard HomeuiStartup12071065151010912531449
load101591513137810591168
domContentLoaded101391113127810591162
domInteractive55292353681125
firstPaint------
backgroundConnect3721143203887
firstReactRender21173642134
getState106647920
initialActions103112
loadScripts99390112337310321152
setupStore1158012936
numNetworkReqs1156515759
BrowserifyPower User HomeuiStartup26692155378633228723450
load1181942167617912941544
domContentLoaded1180936167617912931544
domInteractive14732722130179448
firstPaint------
backgroundConnect211211112253227830
firstReactRender86471521995131
getState24079884253188854
initialActions4056738
loadScripts1151923165417612461516
setupStore97678714895495
numNetworkReqs89612063987187
WebpackStandard HomeuiStartup13981242181710614471628
load1185106114458512411342
domContentLoaded1185106114458512411342
domInteractive51261412974122
firstPaint------
backgroundConnect3819111174173
firstReactRender26196262836
getState10611311918
initialActions106122
loadScripts1163104713708012211319
setupStore13579141039
numNetworkReqs1157215655
WebpackPower User HomeuiStartup28301959371531230373465
load13901096193419315791753
domContentLoaded13891096193319315791753
domInteractive11729520119120442
firstPaint------
backgroundConnect14425622138192492
firstReactRender90431612399137
getState31063929294457885
initialActions3037537
loadScripts13501081189518815141709
setupStore1066800172102717
numNetworkReqs91592164295198
📊 Page Load Benchmark Results

Current Commit: 54370c5 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±45ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 720ms (±65ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 88ms (±131ms) 🟢 | historical mean value: 80ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 45ms 1.00s 1.40s 1.05s 1.40s
domContentLoaded 720ms 65ms 697ms 1.32s 738ms 1.32s
firstPaint 88ms 131ms 60ms 1.39s 88ms 1.39s
firstContentfulPaint 88ms 131ms 60ms 1.39s 88ms 1.39s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: -38 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [bc3200e]
UI Startup Metrics (1213 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12131011153110012571409
load102986013058910731213
domContentLoaded102285512978810661200
domInteractive2715196292195
firstPaint5608812433949961108
backgroundConnect21519629113218236
firstReactRender301982103451
getState331670124261
initialActions103112
loadScripts815652109987857994
setupStore1272441422
numNetworkReqs1257720573
BrowserifyPower User HomeuiStartup18741563299627619962459
load100287919461769901449
domContentLoaded98887319361759711436
domInteractive39172074728186
firstPaint5708014723809281084
backgroundConnect21919825810225241
firstReactRender84471581589105
getState17412833344189271
initialActions103112
loadScripts78467617311757711231
setupStore20954102739
numNetworkReqs90672013294183
WebpackStandard HomeuiStartup76365997476794947
load59553280869615775
domContentLoaded59152480269610769
domInteractive2513120251898
firstPaint22174711146202601
backgroundConnect952741017
firstReactRender2619120113136
getState23135292939
initialActions104111
loadScripts58852279467608762
setupStore1043141117
numNetworkReqs1257820573
WebpackPower User HomeuiStartup14251194251823615541901
load6635711349136660997
domContentLoaded6535641337135645991
domInteractive40172295029186
firstPaint269911086188263660
backgroundConnect1575371726
firstReactRender8252114118999
getState15312026031163223
initialActions102012
loadScripts6505621324133643982
setupStore22860133250
numNetworkReqs1456531758189288
FirefoxBrowserifyStandard HomeuiStartup12911099171112913481575
load107994113229111411246
domContentLoaded107894013219111401246
domInteractive65311633587136
firstPaint------
backgroundConnect42231482344100
firstReactRender23185862436
getState1063551022
initialActions102012
loadScripts105392512758411051216
setupStore126101111231
numNetworkReqs1256817663
BrowserifyPower User HomeuiStartup26491793369037828953306
load1156929170120712821567
domContentLoaded1155929170120712821567
domInteractive12732590134131522
firstPaint------
backgroundConnect199281178245212723
firstReactRender89391421998130
getState22271893229197838
initialActions3058627
loadScripts1114902164020011971545
setupStore985776149116552
numNetworkReqs91612224384199
WebpackStandard HomeuiStartup14231251192111614741671
load1210106015019412711379
domContentLoaded1210106015019412701379
domInteractive51261633171128
firstPaint------
backgroundConnect4017106184292
firstReactRender26196962735
getState136161211020
initialActions103012
loadScripts1186104414718812491339
setupStore155139211368
numNetworkReqs1156716660
WebpackPower User HomeuiStartup28562200372835030633534
load14011118189620515721796
domContentLoaded14011118189620515721796
domInteractive12932636137119504
firstPaint------
backgroundConnect16027795184195612
firstReactRender87401521996121
getState31383941283483881
initialActions4153547
loadScripts13681094180920015411742
setupStore1306859209108750
numNetworkReqs92602144482210
📊 Page Load Benchmark Results

Current Commit: bc3200e | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±45ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 731ms (±41ms) 🟢 | historical mean value: 731ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 45ms 1.01s 1.36s 1.07s 1.36s
domContentLoaded 731ms 41ms 704ms 1.01s 748ms 1.01s
firstPaint 78ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 78ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 445 Bytes (0.01%)
  • common: 126 Bytes (0%)

OGPoyraz
OGPoyraz previously approved these changes Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [228e28d]
UI Startup Metrics (1230 ± 117 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12301008158211712881451
load1042865132510510981248
domContentLoaded1036862131310410931235
domInteractive28151202522103
firstPaint58991131343110521239
backgroundConnect21619325912221241
firstReactRender3120139133350
getState351766113958
initialActions106112
loadScripts82665710971008721028
setupStore1273641419
numNetworkReqs1257821575
BrowserifyPower User HomeuiStartup18301575225617319372181
load98785815741549701421
domContentLoaded97485315491549571410
domInteractive39171974331159
firstPaint6089515843969411444
backgroundConnect21820025010222239
firstReactRender83401342191126
getState16612824327185218
initialActions105113
loadScripts77166513211537551217
setupStore1994792437
numNetworkReqs101653004298191
WebpackStandard HomeuiStartup810686115782837992
load62756485170643816
domContentLoaded62355884569639811
domInteractive27151182622108
firstPaint26081851199242705
backgroundConnect1053151224
firstReactRender27194263039
getState281468113749
initialActions103112
loadScripts62055583767637802
setupStore1163951219
numNetworkReqs1257720573
WebpackPower User HomeuiStartup14151207197315215231688
load6655821202117659988
domContentLoaded6555751190117647983
domInteractive39182144432169
firstPaint261911201190231662
backgroundConnect1484561621
firstReactRender81441071591101
getState14912320417158190
initialActions105112
loadScripts6525731180115645974
setupStore21966142450
numNetworkReqs1466631657189299
FirefoxBrowserifyStandard HomeuiStartup12191081153510012751457
load102692012367910711190
domContentLoaded102591412367910701189
domInteractive58301813579145
firstPaint------
backgroundConnect32228293551
firstReactRender22175452234
getState11512214934
initialActions102122
loadScripts100690412147810461170
setupStore116498931
numNetworkReqs1156614653
BrowserifyPower User HomeuiStartup23961893307023025632819
load1121915158415211371463
domContentLoaded1120915158415211371463
domInteractive11833504106115395
firstPaint------
backgroundConnect962742566108210
firstReactRender84421712297124
getState26661841207373699
initialActions308237
loadScripts1088900156214511151424
setupStore1237803167104550
numNetworkReqs915521036111166
WebpackStandard HomeuiStartup14511289183611614871739
load1226109314868712661407
domContentLoaded1226109314868712661407
domInteractive58261463179127
firstPaint------
backgroundConnect4121140224294
firstReactRender27206872839
getState136128171219
initialActions102012
loadScripts1201107314248012441377
setupStore13690121233
numNetworkReqs1156916661
WebpackPower User HomeuiStartup26852248390625928063161
load13861154190917014331743
domContentLoaded13851154190817014321743
domInteractive11629489106105427
firstPaint------
backgroundConnect1042743558122234
firstReactRender81441731991112
getState308641085244511802
initialActions3041538
loadScripts13511133188216414011708
setupStore1047761148106541
numNetworkReqs916019436108162
📊 Page Load Benchmark Results

Current Commit: 228e28d | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±41ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±39ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 41ms 1.00s 1.36s 1.06s 1.36s
domContentLoaded 717ms 39ms 697ms 1.02s 734ms 1.02s
firstPaint 75ms 11ms 56ms 156ms 88ms 156ms
firstContentfulPaint 75ms 11ms 56ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1002 Bytes (0.02%)
  • ui: 765 Bytes (0.01%)
  • common: 126 Bytes (0%)

@jpuri jpuri requested a review from OGPoyraz November 24, 2025 13:38
OGPoyraz
OGPoyraz previously approved these changes Nov 24, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [de9c6fe]
UI Startup Metrics (1283 ± 112 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12831055166111213291514
load107989513569811251266
domContentLoaded107288913409611181258
domInteractive2816112242295
firstPaint58196136543810781255
backgroundConnect22320227512227250
firstReactRender33216093951
getState3718102144465
initialActions106113
loadScripts8576761105959011050
setupStore1383951424
numNetworkReqs1257820574
BrowserifyPower User HomeuiStartup19771607325329521402593
load98687817271529691362
domContentLoaded97387117141519521351
domInteractive35161983729136
firstPaint5328217303919241360
backgroundConnect21820025910224239
firstReactRender88431422097127
getState16512427231186224
initialActions1011113
loadScripts77067214991507501137
setupStore21980142554
numNetworkReqs104672865699271
WebpackStandard HomeuiStartup8507191206928871057
load65856589880705836
domContentLoaded65356287379699829
domInteractive2816117232392
firstPaint26875880205229762
backgroundConnect95324918
firstReactRender28208593341
getState281394143747
initialActions103112
loadScripts65055986478696820
setupStore1143341319
numNetworkReqs1257721574
WebpackPower User HomeuiStartup14721207202021915701916
load659580110199656929
domContentLoaded650574109099644923
domInteractive37172623733129
firstPaint293961109207352686
backgroundConnect1485571626
firstReactRender83441061491102
getState1417520218153176
initialActions103012
loadScripts647572107997642915
setupStore19956122253
numNetworkReqs101652945798280
FirefoxBrowserifyStandard HomeuiStartup12391089170611412831460
load103692513787910811179
domContentLoaded103492413787910801179
domInteractive66301853491129
firstPaint------
backgroundConnect3722169223780
firstReactRender22185362236
getState96505918
initialActions102012
loadScripts101590913497710561160
setupStore1063861029
numNetworkReqs1156615652
BrowserifyPower User HomeuiStartup25122042335027226932938
load1136978169216111461525
domContentLoaded1136978169216111461525
domInteractive12433635115114462
firstPaint------
backgroundConnect992642663105262
firstReactRender84471522295125
getState25857861215332753
initialActions318227
loadScripts1105954160815511061497
setupStore1278782178106613
numNetworkReqs103613116196255
WebpackStandard HomeuiStartup14211281198711314731655
load1209106814628912811381
domContentLoaded1209106714618912811381
domInteractive55272223473126
firstPaint------
backgroundConnect4016127194470
firstReactRender26208082834
getState125161181018
initialActions102122
loadScripts1185105314308512551352
setupStore12677121040
numNetworkReqs1156615653
WebpackPower User HomeuiStartup26812146372829829033216
load13691184190917314091718
domContentLoaded13691184190917314091718
domInteractive10932470101101432
firstPaint------
backgroundConnect1002346269117237
firstReactRender80401191592104
getState26851793224413777
initialActions3136437
loadScripts13331156182416013571688
setupStore12610693161134562
numNetworkReqs100562605780242
📊 Page Load Benchmark Results

Current Commit: de9c6fe | Date: 11/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±37ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.32s 1.07s 1.32s
domContentLoaded 723ms 37ms 696ms 993ms 756ms 993ms
firstPaint 77ms 10ms 64ms 152ms 88ms 152ms
firstContentfulPaint 77ms 10ms 64ms 152ms 88ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.1 KiB (0.02%)
  • ui: 10.04 KiB (0.14%)
  • common: 237 Bytes (0%)

OGPoyraz
OGPoyraz previously approved these changes Nov 25, 2025
cryptotavares
cryptotavares previously approved these changes Nov 25, 2025
@jpuri jpuri added this pull request to the merge queue Nov 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 25, 2025
@jpuri jpuri dismissed stale reviews from cryptotavares and OGPoyraz via 5ecb088 November 25, 2025 12:12
@jpuri jpuri enabled auto-merge November 25, 2025 12:14
@metamaskbot
Copy link
Collaborator

Builds ready [5ecb088]
UI Startup Metrics (1342 ± 125 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13421106167212514041590
load1070890137010011331256
domContentLoaded106388513619911261250
domInteractive2715110232196
firstPaint53684137541910211219
backgroundConnect21719826112223241
firstReactRender37216584258
getState64191673175138
initialActions109113
loadScripts8546791161979121039
setupStore1573561729
numNetworkReqs41281473430145
BrowserifyPower User HomeuiStartup22401823296226723902830
load986847162014510021351
domContentLoaded97383715931449871339
domInteractive33162123131111
firstPaint6939214763839721231
backgroundConnect243182649105231593
firstReactRender964316527117140
getState19114427028210245
initialActions105112
loadScripts77463813831377861143
setupStore21977132347
numNetworkReqs1406939270177321
WebpackStandard HomeuiStartup90673216381319271140
load6675681214103718883
domContentLoaded6625641195101713877
domInteractive29161452624103
firstPaint23277933160220624
backgroundConnect1053861120
firstReactRender3822153203788
getState59161853184108
initialActions104112
loadScripts6595621184100709868
setupStore147116121436
numNetworkReqs41281453331142
WebpackPower User HomeuiStartup18341325253424519842247
load6875921248108695953
domContentLoaded6775841241108684947
domInteractive36181803132123
firstPaint325101990228443765
backgroundConnect84864417422594
firstReactRender914512921110122
getState18612471977192233
initialActions103112
loadScripts6745821231107682938
setupStore21951132449
numNetworkReqs1557239675195385
FirefoxBrowserifyStandard HomeuiStartup14171175196719815181843
load1066928153712711151327
domContentLoaded1064928153712711111327
domInteractive58272683783115
firstPaint------
backgroundConnect68242775081208
firstReactRender28186293150
getState2411115152455
initialActions203123
loadScripts1036887151712010631273
setupStore2611166292195
numNetworkReqs40271292832122
BrowserifyPower User HomeuiStartup26922008481746128183528
load1154988246518711781466
domContentLoaded1153983246518711781465
domInteractive12534491105117442
firstPaint------
backgroundConnect152271523182144423
firstReactRender903825731106138
getState29250917214354792
initialActions208123
loadScripts1118947232017711451437
setupStore17215846192183688
numNetworkReqs100573196379238
WebpackStandard HomeuiStartup16731382238919717872034
load13011137171911613731512
domContentLoaded13011137171911613731512
domInteractive59282123884140
firstPaint------
backgroundConnect70203045376201
firstReactRender3321103103849
getState2891382527105
initialActions204123
loadScripts12711114165610713361479
setupStore2791552824105
numNetworkReqs40281312732124
WebpackPower User HomeuiStartup30362244613270431134848
load14711173314242114442861
domContentLoaded14701173314142114442861
domInteractive123331184145102407
firstPaint------
backgroundConnect1383251896156376
firstReactRender924822428102134
getState29686927217392762
initialActions207123
loadScripts14221152295636914182375
setupStore16091039206163663
numNetworkReqs100612625978245
📊 Page Load Benchmark Results

Current Commit: 5ecb088 | Date: 11/25/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±46ms) 🟡 | historical mean value: 1.03s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 718ms (±42ms) 🟢 | historical mean value: 721ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±15ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 46ms 1.01s 1.40s 1.08s 1.40s
domContentLoaded 718ms 42ms 697ms 1.06s 737ms 1.06s
firstPaint 77ms 15ms 56ms 208ms 84ms 208ms
firstContentfulPaint 77ms 15ms 56ms 208ms 84ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: -77 Bytes (0%)
  • common: 20 Bytes (0%)

@jpuri jpuri added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 46874fe Nov 25, 2025
172 checks passed
@jpuri jpuri deleted the latency_metrics_fix branch November 25, 2025 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.12.0 Issue or pull request that will be included in release 13.12.0 size-S team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants