Skip to content

Conversation

@zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 24, 2025

Description

We were missing the TRX Methods being added to the selector selectCanSignTransactions.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds TRX SignMessageV2 to selectCanSignTransactions and updates tests to cover TRX accounts.

  • Selectors:
    • Include TRX SignMessageV2 in selectCanSignTransactions (app/selectors/accountsController.ts).
  • Tests:
    • Import TRX types and add TRX account case asserting selectCanSignTransactions returns true (app/selectors/accountsController.test.ts).

Written by Cursor Bugbot for commit 1df7e39. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-S and removed size-XS labels Oct 24, 2025
@sonarqubecloud
Copy link

@zone-live zone-live added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 7297ac0 Oct 27, 2025
83 checks passed
@zone-live zone-live deleted the NWNT-add-TrxMethod-to-selector branch October 27, 2025 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
@metamaskbot metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.59.0 Issue or pull request that will be included in release 7.59.0 size-S team-new-networks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants