feat: viewable navigator in settings to testers and developers to view viewable feature flags #21639

sallem-consensys · 2025-10-24T18:48:40Z

Description

This PR is to show users the fetched feature flags that they pulled from the launch darkly api.

Changelog

CHANGELOG entry: added viewable navigator in settings to testers and developers to view release flag

Related issues

Manual testing steps

Feature: Viewable Feature flags

  Scenario: user views feature flag dashboard
    Given basic functionality is toggled on

    When user navigates to settings Feature Flag Override
    Then they will see a dashboard to view the feature flags they have activated

Screenshots/Recordings

Before

no feature flag override page as it did not exist

After

preview-demo-feature-flag-override.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds a non‑production Feature Flag Override screen with override management, wired into Settings/navigation, backed by a new context, hook, and utilities, with tests and i18n updates.

UI:
- Add Views/FeatureFlagOverride screen to list/search/filter flags and edit/reset overrides; displays stats via useFeatureFlagStats.
Navigation/Settings:
- Register Routes.FEATURE_FLAG_OVERRIDE and conditionally add FeatureFlagOverride screen and Settings drawer item (non‑production only).
State/Context:
- Introduce FeatureFlagOverrideProvider context for managing overrides (set/remove/clear, apply, count) and expose processed FeatureFlagInfo list.
- Wrap app root with FeatureFlagOverrideProvider.
Hooks/Utils:
- Add useFeatureFlagStats hook for flag type counts.
- Add feature‑flag utilities: getFeatureFlagType, getFeatureFlagDescription, isMinimumRequiredVersionSupported.
Localization:
- Add en strings for Settings “Feature Flag Override”.
Tests:
- Comprehensive tests for the new screen, context, hook, utilities, and updated snapshots.

^{Written by Cursor Bugbot for commit b80c37a. This will update automatically on new commits. Configure here.}

github-actions · 2025-10-24T18:48:54Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tommasini · 2025-10-28T19:21:36Z

app/components/Views/FeatureFlagOverride/FeatureFlagOverride.tsx

@@ -0,0 +1,443 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */


We shouldn't disable eslint rules

using unknown resolves this

tommasini · 2025-10-28T19:24:44Z

app/components/Nav/Main/MainNavigator.js

          ...GeneralSettings.navigationOptions,
        }}
      />
+      <Stack.Screen


Should we only initialize this stack if not production?

tommasini · 2025-10-28T19:27:07Z

app/contexts/FeatureFlagOverrideContext.tsx

@@ -0,0 +1,174 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */


We shouldn't disable the usage of any

resolved with unknown

Can we remove the disable?

tommasini · 2025-10-28T19:28:29Z

app/contexts/README.md

@@ -0,0 +1,133 @@
+# Feature Flag Override Context


I dont think we need this documentation for the feature, its self explanatory, wdyt?

If you think otherwise, we should change the name of the file to reflect what it is

ok will remove

tommasini · 2025-10-28T19:28:42Z

app/hooks/useFeatureFlagStats.test.ts

@@ -0,0 +1,456 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */


We shouldn't disable lint rules

enabled rule again

tommasini · 2025-10-28T19:29:13Z

app/util/feature-flags/index.ts

@@ -0,0 +1,76 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */


We shouldn't disable lint rules

converted to unknown

tommasini · 2025-10-28T21:14:14Z

app/components/Nav/Main/MainNavigator.js

          ...GeneralSettings.navigationOptions,
        }}
      />
+      {process.env.MM_ENABLE_FEATURE_FLAG_OVERRIDE === 'true' && (


Is this true for rc builds?

just prod builds updated

- Reverted all language files except en.json to main branch state - Kept only the feature_flag_override additions in en.json

cursor · 2025-10-29T16:56:46Z

app/components/Views/FeatureFlagOverride/FeatureFlagOverride.tsx

+            thumbColor={theme.brandColors.white}
+            ios_backgroundColor={theme.colors.border.muted}
+          />
+        );


Bug: Boolean Switch Component Unintentionally Disabled

The Switch component for boolean feature flags is unexpectedly disabled, preventing users from toggling them. This makes the onValueChange handler unreachable and defeats the purpose of overriding boolean flags, which tests expect to be functional. This behavior differs from the boolean with minimumVersion type, where the disabled prop is intentionally commented out with a TODO.

this PR is for read only currently

sonarqubecloud · 2025-10-29T17:17:35Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sallem-consensys requested review from a team as code owners October 24, 2025 18:48

sallem-consensys self-assigned this Oct 24, 2025

metamaskbot added the team-mobile-platform Mobile Platform team label Oct 24, 2025

github-actions bot added the size-L label Oct 24, 2025

This comment was marked as outdated.

Sign in to view

github-actions bot added size-XL and removed size-L labels Oct 24, 2025

sallem-consensys changed the title ~~Feat/viewable navigator in settings to testers and developers to view viewable feature flags~~ feat/viewable navigator in settings to testers and developers to view viewable feature flags Oct 27, 2025

sallem-consensys changed the title ~~feat/viewable navigator in settings to testers and developers to view viewable feature flags~~ feat: viewable navigator in settings to testers and developers to view viewable feature flags Oct 27, 2025

This comment was marked as outdated.

Sign in to view

sallem-consensys force-pushed the feat/ffr-mwmr-175 branch 2 times, most recently from ff74a75 to 58d51c8 Compare October 28, 2025 17:05

This comment was marked as outdated.

Sign in to view

tommasini reviewed Oct 28, 2025

View reviewed changes

sallem-consensys requested a review from tommasini October 28, 2025 21:02

tommasini previously approved these changes Oct 28, 2025

View reviewed changes

tommasini reviewed Oct 28, 2025

View reviewed changes

sallem-consensys dismissed tommasini’s stale review via c090b05 October 28, 2025 21:33

This comment was marked as outdated.

Sign in to view

sallem-consensys force-pushed the feat/ffr-mwmr-175 branch from dc9b8c1 to 2b23355 Compare October 29, 2025 09:37

sallem-consensys requested a review from tommasini October 29, 2025 10:32

tommasini previously approved these changes Oct 29, 2025

View reviewed changes

sallem-consensys enabled auto-merge October 29, 2025 15:49

sallem-consensys dismissed tommasini’s stale review via 018cb86 October 29, 2025 15:52

sallem-consensys requested a review from tommasini October 29, 2025 15:52

sallem-consensys force-pushed the feat/ffr-mwmr-175 branch from 018cb86 to 35aabbb Compare October 29, 2025 16:16

sallem-consensys added 17 commits October 29, 2025 12:45

update snapshots

5f5ba28

add test coverage

8ca8f8e

fix test tsc

da332c3

fix test tsc

6de1e0f

fix boolean nested

4873f55

add minimum version support indicator

bd4f50f

fix local value edge case

8865f16

revert: remove changes from all language files except en.json

e44dd8e

address comments to adhere to ts rules

437918b

fix typing

afb1594

fix tsc

f0f479a

flag dashboard only on non production builds

faee2f2

hide feature in production

f8f3b7d

fix lint and format

5bea292

update snapshots

02e7ce2

fix tests

7bd2fdd

fix test

28f1905

sallem-consensys force-pushed the feat/ffr-mwmr-175 branch from 35aabbb to 28f1905 Compare October 29, 2025 16:46

revert: remove locale changes except en.json

b80c37a

- Reverted all language files except en.json to main branch state - Kept only the feature_flag_override additions in en.json

cursor bot reviewed Oct 29, 2025

View reviewed changes

sallem-consensys requested a review from vinnyhoward October 29, 2025 18:01

vinnyhoward approved these changes Oct 29, 2025

View reviewed changes

tommasini approved these changes Oct 29, 2025

View reviewed changes

sallem-consensys added this pull request to the merge queue Oct 29, 2025

Merged via the queue into main with commit aae7ae2 Oct 29, 2025
86 of 87 checks passed

sallem-consensys deleted the feat/ffr-mwmr-175 branch October 29, 2025 18:35

github-actions bot locked and limited conversation to collaborators Oct 29, 2025

metamaskbot added the release-7.59.0 Issue or pull request that will be included in release 7.59.0 label Oct 29, 2025

		@@ -0,0 +1,443 @@
		/* eslint-disable @typescript-eslint/no-explicit-any */

		@@ -0,0 +1,174 @@
		/* eslint-disable @typescript-eslint/no-explicit-any */

		@@ -0,0 +1,456 @@
		/* eslint-disable @typescript-eslint/no-explicit-any */

		@@ -0,0 +1,76 @@
		/* eslint-disable @typescript-eslint/no-explicit-any */

Uh oh!

feat: viewable navigator in settings to testers and developers to view viewable feature flags #21639

feat: viewable navigator in settings to testers and developers to view viewable feature flags #21639

Conversation

sallem-consensys commented Oct 24, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sallem-consensys Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot Oct 29, 2025

Choose a reason for hiding this comment

Bug: Boolean Switch Component Unintentionally Disabled

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 29, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sallem-consensys commented Oct 24, 2025 •

edited by cursor bot

Loading

sallem-consensys Oct 29, 2025 •

edited

Loading