Update main.js - #408
Open
logvik wants to merge 1 commit into
Open
Conversation
Allow a reinitializing. For example, if we change an app language
Author
Member
|
I think this PR should not be approved as it's very specific to an app feature. the package is only using session in https://github.com/Meteor-Community-Packages/meteor-tabular/blob/e9d15a7b758b67bb3930080c4442db9b927393cf/client/main.js and we should convert it to reactiveVar. what do you think? |
Member
|
I think, since the PR is 6 years old we should edit it until it fits the modern requirements. |
Member
|
it will be hard to merge #448 but after it is completed I can work to remove the session. It might be good starting point for me. |
Member
|
If you have any concerns regarding #448 please comment there so we can make this the best possible solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a reinitializing. For example, if we change an app language.
Below you can see a simple way to make i18n for a tabular table. Just change Session.set("currentLanguage", "lang"), where lang is a language of the user and the tabular table will be reinitialized automatically.