fix: accept 0 as valid slippage value by handling falsy check #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekamalsain
commented
Jan 27, 2025
thekamalsain
commented
- Resolved an issue where slippage value of 0 was incorrectly treated as falsy, causing it to default to MAX_ACTIVE_BIN_SLIPPAGE.
- Updated the logic to explicitly check for null or undefined, allowing 0 to be correctly processed.
- Resolved an issue where slippage value of 0 was incorrectly treated as falsy, causing it to default to MAX_ACTIVE_BIN_SLIPPAGE. - Updated the logic to explicitly check for null or undefined, allowing 0 to be correctly processed.
|
@thekamalsain I am trying to set slippage to 1%, do you know if I should enter 1, 0.01, or 100 for slippage? Thanks in advance! |
Author
@jorgez19 Yes, you need to pass it as 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.