Skip to content

Linking to libraries that support the pattern #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Linking to libraries that support the pattern #3834

merged 1 commit into from
Jan 5, 2023

Conversation

udidahan
Copy link
Contributor

As was already accepted in #3609.

@opbld33
Copy link

opbld33 commented Dec 27, 2022

Learn Build status updates of commit 717b474:

✅ Validation status: passed

File Status Preview URL Details
docs/best-practices/transactional-outbox-cosmos-content.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@ckittel
Copy link
Member

ckittel commented Dec 27, 2022

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@jborsecnik
Copy link
Contributor

@mSarts,

Can you review the proposed changes? If someone else should, please advise.

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Dec 27, 2022
@mSarts mSarts removed their assignment Dec 28, 2022
@mSarts
Copy link
Contributor

mSarts commented Dec 28, 2022

@alexhart11 Please review the thread above.

@alexhart11
Copy link
Contributor

#sign-off

@prmerger-automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@udidahan
Copy link
Contributor Author

udidahan commented Jan 4, 2023

Hey folks, any chance of getting this moving again? Thanks :)

@ckittel
Copy link
Member

ckittel commented Jan 4, 2023

@jborsecnik ^

@ckittel
Copy link
Member

ckittel commented Jan 5, 2023 •
edited
Loading

@JanetCThomas / @alexhart11 - can you find out why this is being held up? We've got CACT review done and two content PM sign offs done, just PR merger is pending. @jborsecnik, can you help us identify whatever is still blocking on this?

@jborsecnik jborsecnik self-requested a review January 5, 2023 19:19
@jborsecnik
Copy link
Contributor

jborsecnik commented Jan 5, 2023 •
edited
Loading

The delay is because this is in the public repo, so it travels a different process path. But I was able to add myself as a reviewer and approve/merge.

@jborsecnik jborsecnik merged commit 9c5bee2 into MicrosoftDocs:main Jan 5, 2023
@jborsecnik
Copy link
Contributor

@ckittel - I will keep an eye on this issue in case any process adjustment is needed on our part (PR review team).

@udidahan udidahan deleted the patch-9 branch January 8, 2023 13:03
@udidahan
Copy link
Contributor Author

udidahan commented Jan 8, 2023

Thanks very much everyone.

Process-wise, should I have done anything differently on my end?

@ckittel
Copy link
Member

ckittel commented Jan 9, 2023

No change on your end, @udidahan -- but thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborsecnik jborsecnik jborsecnik approved these changes

Assignees
No one assigned
Labels
aq-pr-triaged Tracking label for the PR review team do-not-merge qualifies-for-auto-merge review-team-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@udidahan @opbld33 @ckittel @jborsecnik @mSarts @alexhart11